Bug 212101 - Repaint issues when the login field collapses on music.apple.com
Summary: Repaint issues when the login field collapses on music.apple.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-19 12:40 PDT by zalan
Modified: 2020-05-20 18:44 PDT (History)
11 users (show)

See Also:


Attachments
Patch (12.35 KB, patch)
2020-05-19 17:46 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (6.82 KB, patch)
2020-05-20 14:10 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-05-19 12:40:43 PDT
<rdar://problem/62874369>
Comment 1 zalan 2020-05-19 17:46:22 PDT
Created attachment 399791 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-05-19 19:02:53 PDT
Comment on attachment 399791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399791&action=review

> Source/WebCore/page/FrameView.h:541
> +    void setSubframeRepaintTrackingIsEnabled(bool enable) { m_isTrackingSubframeRepaints = enable; }
> +    bool isTrackingSubframeRepaints() const { return m_isTrackingSubframeRepaints; }

This is a bit ambiguous living on FrameView. Which subframes are tracked? Do the repaints live on the subframe's FrameViews? How do you get at those via internals?

> Source/WebCore/rendering/RenderObject.h:629
> +        bool m_hasPositionFixedDescendant { false };
> +        bool m_dirtyRectIsFlipped { false };
> +        bool m_needsEnclosingIntRect { false };

Normally we skip the m_ prefix on public member vars.

> LayoutTests/fast/repaint/iframe-on-subpixel-position.html:42
> +<div class=container><div><iframe onload="runRepaintTest()" id=subpixel_iframe frameborder=no src='data: text/html,

srcdoc?
Comment 3 zalan 2020-05-19 19:05:34 PDT
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 399791 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399791&action=review
> 
> > Source/WebCore/page/FrameView.h:541
> > +    void setSubframeRepaintTrackingIsEnabled(bool enable) { m_isTrackingSubframeRepaints = enable; }
> > +    bool isTrackingSubframeRepaints() const { return m_isTrackingSubframeRepaints; }
> 
> This is a bit ambiguous living on FrameView. Which subframes are tracked? Do
> the repaints live on the subframe's FrameViews? How do you get at those via
> internals?
Do you have a suggestion how to track repaints inside iframe?
Comment 4 zalan 2020-05-20 14:10:24 PDT
Created attachment 399891 [details]
Patch
Comment 5 EWS 2020-05-20 18:44:16 PDT
Committed r261979: <https://trac.webkit.org/changeset/261979>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399891 [details].