<rdar://problem/62874369>
Created attachment 399791 [details] Patch
Comment on attachment 399791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399791&action=review > Source/WebCore/page/FrameView.h:541 > + void setSubframeRepaintTrackingIsEnabled(bool enable) { m_isTrackingSubframeRepaints = enable; } > + bool isTrackingSubframeRepaints() const { return m_isTrackingSubframeRepaints; } This is a bit ambiguous living on FrameView. Which subframes are tracked? Do the repaints live on the subframe's FrameViews? How do you get at those via internals? > Source/WebCore/rendering/RenderObject.h:629 > + bool m_hasPositionFixedDescendant { false }; > + bool m_dirtyRectIsFlipped { false }; > + bool m_needsEnclosingIntRect { false }; Normally we skip the m_ prefix on public member vars. > LayoutTests/fast/repaint/iframe-on-subpixel-position.html:42 > +<div class=container><div><iframe onload="runRepaintTest()" id=subpixel_iframe frameborder=no src='data: text/html, srcdoc?
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 399791 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399791&action=review > > > Source/WebCore/page/FrameView.h:541 > > + void setSubframeRepaintTrackingIsEnabled(bool enable) { m_isTrackingSubframeRepaints = enable; } > > + bool isTrackingSubframeRepaints() const { return m_isTrackingSubframeRepaints; } > > This is a bit ambiguous living on FrameView. Which subframes are tracked? Do > the repaints live on the subframe's FrameViews? How do you get at those via > internals? Do you have a suggestion how to track repaints inside iframe?
Created attachment 399891 [details] Patch
Committed r261979: <https://trac.webkit.org/changeset/261979> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399891 [details].