Bug 212097 – Blue dotted underline with alternatives only shown for last word, gets lost for previous insertions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

When space separated dictation alternatives are inserted only the last inserted one has blue dots.

[Daniel Bates]

<rdar://problem/61913405>

[Daniel Bates]

Created attachment 399763 [details]
Patch

[Daniel Bates]

Comment on attachment 399763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399763&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm:365
> +    // FIXME: Set CSS white-space to workaround <https://webkit.org/b/212093>.

Actually, works around <https://webkit.org/b/212098> because space converted to no-break space.

[Daniel Bates]

Created attachment 399770 [details]
Patch

Just cosmetic fixing of comments

[Daniel Bates]

Comment on attachment 399770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399770&action=review

> Source/WebCore/ChangeLog:28
> +        if it is a space or newline. This will be false when there is no preceeding character (e.g. start of document),

preceeding => preceding

> Source/WebCore/ChangeLog:31
> +        because that would incorrectly return false if the current selection is at the of a paragraph. I could have

the of => the end of

> Source/WebCore/ChangeLog:35
> +        start of the last word positions before mutating them. Update early returns checks to use these saved values

returns => return

> Source/WebCore/ChangeLog:40
> +        * editing/Editor.h: While I am here, fix up a param name to match the what it is called in the impl.

the what => what
impl => .cpp

[Daniel Bates]

Thanks Darin.

[Daniel Bates]

Created attachment 399785 [details]
To Land

[Daniel Bates]

Committed r261897: <https://trac.webkit.org/changeset/261897>