Bug 212095 - Make union initializers for JSC::PropertySlot more explicit about which field is being initialized
Summary: Make union initializers for JSC::PropertySlot more explicit about which field...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL: https://en.cppreference.com/w/cpp/lan...
Keywords:
Depends on: 211267
Blocks:
  Show dependency tree / graph
 
Reported: 2020-05-19 11:26 PDT by David Kilzer (:ddkilzer)
Modified: 2020-05-19 12:19 PDT (History)
11 users (show)

See Also:

Attachments
Patch v1 (1.90 KB, patch)
2020-05-19 11:29 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-05-19 11:26:00 PDT 
Make union initializers for JSC::PropertySlot more explicit on which field is being initialized.

This is a follow-up to Bug 211267: REGRESSION (r154253): JSC::PropertySlot::m_attributes is uninitialized in constructor.

See Bug 211267 Comment #7: <https://bugs.webkit.org/show_bug.cgi?id=211267#c7>
Comment 1 David Kilzer (:ddkilzer) 2020-05-19 11:29:57 PDT 
Created attachment 399754 [details]
Patch v1
Comment 2 Mark Lam 2020-05-19 11:33:18 PDT 
Comment on attachment 399754 [details]
Patch v1

Neat, but the Windows bots don't seem to like this change.
Comment 3 David Kilzer (:ddkilzer) 2020-05-19 11:57:37 PDT 
(In reply to Mark Lam from comment #2)
> Comment on attachment 399754 [details]
> Patch v1
> 
> Neat, but the Windows bots don't seem to like this change.

Ha!

C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\runtime\PropertySlot.h(389): error C7555: use of designated initializers requires at least '/std:c++latest'
C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\runtime\PropertySlot.h(404): error C7555: use of designated initializers requires at least '/std:c++latest'

I guess we can hold off on this until the Windows bots add the '/std:c++latest' switch in the future.