Bug 212090 - SQLite database fails to close in SQLiteIDBBackingStore::databaseNameFromFile
Summary: SQLite database fails to close in SQLiteIDBBackingStore::databaseNameFromFile
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-19 10:24 PDT by Sihui Liu
Modified: 2020-05-21 11:04 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2020-05-19 10:27 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (1.83 KB, patch)
2020-05-21 10:32 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-05-19 10:24:49 PDT 
...
Comment 1 Sihui Liu 2020-05-19 10:27:38 PDT 
Created attachment 399747 [details]
Patch
Comment 2 Darin Adler 2020-05-19 17:46:50 PDT 
Comment on attachment 399747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399747&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:924
>          database.close();

I suggest removing this line of code also.

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:-929
> -    database.close();

I don’t think you need to do the rest of this change. Just removing this line of code alone should fix the bug, without the restructuring.
Comment 3 Sihui Liu 2020-05-21 10:32:23 PDT 
Created attachment 399965 [details]
Patch for landing
Comment 4 EWS 2020-05-21 11:03:02 PDT 
Committed r262015: <https://trac.webkit.org/changeset/262015>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399965 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-21 11:04:14 PDT 
<rdar://problem/63501180>