RESOLVED FIXED 212071
[Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource 
https://bugs.webkit.org/show_bug.cgi?id=212071
Summary [Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource
youenn fablet
Reported 2020-05-19 07:17:35 PDT
[Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource
Attachments
Patch (1.48 KB, patch)
2020-05-19 07:20 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (2.65 KB, patch)
2020-05-20 02:27 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-05-19 07:20:24 PDT
Created attachment 399732 [details] Patch
Eric Carlson
Comment 2 2020-05-19 09:52:37 PDT
Comment on attachment 399732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399732&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:-83 > - // FIXME: Use preferedPixelBufferFormat() once rdar://problem/44391444 is fixed. > -#if PLATFORM(MAC) > - return kCVPixelFormatType_420YpCbCr8Planar; > -#else > return preferedPixelBufferFormat(); > -#endif We should make this conditional on the build target since the fix is unlikely to be back ported. Maybe define something like HAVE_DISPLAY_LAYER_PLANAR_SUPPORT?
youenn fablet
Comment 3 2020-05-19 11:37:45 PDT
(In reply to Eric Carlson from comment #2) > Comment on attachment 399732 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399732&action=review > > > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:-83 > > - // FIXME: Use preferedPixelBufferFormat() once rdar://problem/44391444 is fixed. > > -#if PLATFORM(MAC) > > - return kCVPixelFormatType_420YpCbCr8Planar; > > -#else > > return preferedPixelBufferFormat(); > > -#endif > > We should make this conditional on the build target since the fix is > unlikely to be back ported. Maybe define something like > HAVE_DISPLAY_LAYER_PLANAR_SUPPORT? Oh right, will do!
youenn fablet
Comment 4 2020-05-20 02:27:21 PDT
Created attachment 399823 [details] Patch
EWS
Comment 5 2020-05-20 06:30:48 PDT
Committed r261915: <https://trac.webkit.org/changeset/261915> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399823 [details].
Radar WebKit Bug Importer
Comment 6 2020-05-20 06:31:15 PDT
<rdar://problem/63444589>
Note You need to log in before you can comment on or make changes to this bug.