Bug 212071 - [Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource
Summary: [Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-19 07:17 PDT by youenn fablet
Modified: 2020-05-20 06:31 PDT (History)
13 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2020-05-19 07:20 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.65 KB, patch)
2020-05-20 02:27 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-05-19 07:17:35 PDT 
[Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource
Comment 1 youenn fablet 2020-05-19 07:20:24 PDT 
Created attachment 399732 [details]
Patch
Comment 2 Eric Carlson 2020-05-19 09:52:37 PDT 
Comment on attachment 399732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399732&action=review

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:-83
> -    // FIXME: Use preferedPixelBufferFormat() once rdar://problem/44391444 is fixed.
> -#if PLATFORM(MAC)
> -    return kCVPixelFormatType_420YpCbCr8Planar;
> -#else
>      return preferedPixelBufferFormat();
> -#endif

We should make this conditional on the build target since the fix is unlikely to be back ported. Maybe define something like HAVE_DISPLAY_LAYER_PLANAR_SUPPORT?
Comment 3 youenn fablet 2020-05-19 11:37:45 PDT 
(In reply to Eric Carlson from comment #2)
> Comment on attachment 399732 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399732&action=review
> 
> > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:-83
> > -    // FIXME: Use preferedPixelBufferFormat() once rdar://problem/44391444 is fixed.
> > -#if PLATFORM(MAC)
> > -    return kCVPixelFormatType_420YpCbCr8Planar;
> > -#else
> >      return preferedPixelBufferFormat();
> > -#endif
> 
> We should make this conditional on the build target since the fix is
> unlikely to be back ported. Maybe define something like
> HAVE_DISPLAY_LAYER_PLANAR_SUPPORT?

Oh right, will do!
Comment 4 youenn fablet 2020-05-20 02:27:21 PDT 
Created attachment 399823 [details]
Patch
Comment 5 EWS 2020-05-20 06:30:48 PDT 
Committed r261915: <https://trac.webkit.org/changeset/261915>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399823 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-20 06:31:15 PDT 
<rdar://problem/63444589>