The WPT test css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails on Mac and iOS The failure its just some small pixel differences in the text rendering, likely related to font kerning differences. See: https://wpt.fyi/analyzer?screenshot=sha1%3Acd49a443027a6deb9e65fdec779db7fd2a3ed532&screenshot=sha1%3A28b192ce9f5c2d626bf5243b8b3e3fa79652cfb0 This test passes on GTK/WPE. Likely this test can be fixed by using Ahem font. For a very similar issue on other of this tests see bug 211891
Created attachment 400219 [details] Patch
Created attachment 400220 [details] Patch
Comment on attachment 400220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400220&action=review r=me, the change looks good just a minor comment about using red color. Apart from that I'm not sure if I need to review the PR in WPT or it's enough with the review here, please let me know. Thanks for the fix. > LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html:25 > + color: red; Please avoid using "red" for things that are on the expected output (as red usually means wrong behavior). Just change it for another color.
(In reply to Manuel Rego Casasnovas from comment #3) > Comment on attachment 400220 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400220&action=review > > r=me, the change looks good just a minor comment about using red color. > Apart from that I'm not sure if I need to review the PR in WPT or it's > enough with the review here, please let me know. Thanks for the fix. > That is not necessary. There is a bot that will approve the WPT PR after getting review here. Check: https://trac.webkit.org/wiki/WPTExportProcess > > LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html:25 > > + color: red; > > Please avoid using "red" for things that are on the expected output (as red > usually means wrong behavior). Just change it for another color. Sure, I will use orange instead. Thanks!
Committed r262139: <https://trac.webkit.org/changeset/262139>
<rdar://problem/63615863>