Bug 212045 - Content disappears on CSS parallax example
Summary: Content disappears on CSS parallax example
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-18 14:35 PDT by Simon Fraser (smfr)
Modified: 2020-05-18 16:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (13.53 KB, patch)
2020-05-18 14:38 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-05-18 14:35:19 PDT 
Content disappears on CSS parallax example
Comment 1 Simon Fraser (smfr) 2020-05-18 14:38:49 PDT 
Created attachment 399674 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-05-18 14:38:52 PDT 
<rdar://problem/63194217>
Comment 3 Dean Jackson 2020-05-18 14:42:31 PDT 
Comment on attachment 399674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399674&action=review

> Source/WebCore/platform/graphics/FloatPoint3D.h:136
> +    a.move(b.x(), b.y());

Wonder if move should return *self?

> Source/WebCore/platform/graphics/FloatPoint3D.h:159
> +    return FloatPoint3D(a.x() + b.x(), a.y() + b.y(), a.z());

What about z?

> Source/WebCore/platform/graphics/FloatPoint3D.h:169
> +    return FloatPoint3D(a.x() - b.x(), a.y() - b.y(), a.z());

Ditto?
Comment 4 Simon Fraser (smfr) 2020-05-18 16:11:13 PDT 
https://trac.webkit.org/changeset/261837/webkit