Bug 212038 - [GTK] Add WEBKIT_EDITING_COMMAND_PASTE_AS_PLAIN_TEXT
Summary: [GTK] Add WEBKIT_EDITING_COMMAND_PASTE_AS_PLAIN_TEXT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-18 12:31 PDT by Michael Catanzaro
Modified: 2020-05-19 06:51 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.99 KB, patch)
2020-05-18 13:04 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Patch (8.99 KB, patch)
2020-05-18 17:53 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-05-18 12:31:48 PDT
We probably need WEBKIT_EDITING_COMMAND_PASTE_AS_PLAINTEXT to go with the new WEBKIT_CONTEXT_MENU_ACTION_PASTE_AS_PLAIN_TEXT from bug #177638.
Comment 1 Michael Catanzaro 2020-05-18 13:04:21 PDT
Created attachment 399668 [details]
Patch
Comment 2 EWS Watchlist 2020-05-18 13:05:00 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2020-05-18 13:05:03 PDT
This test is lazy, it just checks that availability matches the existing paste action (it should, it doesn't need its own separate availability). Let's see if it passes EWS....
Comment 4 Michael Catanzaro 2020-05-18 17:53:04 PDT
Created attachment 399691 [details]
Patch
Comment 5 Michael Catanzaro 2020-05-18 17:53:23 PDT
Ephy impl: https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/672
Comment 6 EWS 2020-05-19 06:51:25 PDT
Committed r261855: <https://trac.webkit.org/changeset/261855>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399691 [details].