Bug 212024 - Allow calling VideoSampleObserver::videoSampleAvailable from a background thread
Summary: Allow calling VideoSampleObserver::videoSampleAvailable from a background thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-18 07:44 PDT by youenn fablet
Modified: 2020-05-20 00:54 PDT (History)
13 users (show)

See Also:

Attachments
Patch (11.29 KB, patch)
2020-05-18 07:50 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (12.64 KB, patch)
2020-05-19 01:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (12.62 KB, patch)
2020-05-19 03:55 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (12.71 KB, patch)
2020-05-20 00:06 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-05-18 07:44:00 PDT 
Allow calling VideoSampleObserver::videoSampleAvailable from a background thread
Comment 1 youenn fablet 2020-05-18 07:50:16 PDT 
Created attachment 399646 [details]
Patch
Comment 2 Eric Carlson 2020-05-18 08:25:11 PDT 
Comment on attachment 399646 [details]
Patch

r=me if the bots are happy
Comment 3 youenn fablet 2020-05-19 01:45:58 PDT 
Created attachment 399725 [details]
Patch for landing
Comment 4 youenn fablet 2020-05-19 03:55:27 PDT 
Created attachment 399727 [details]
Patch for landing
Comment 5 EWS 2020-05-19 06:57:54 PDT 
Committed r261856: <https://trac.webkit.org/changeset/261856>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399727 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-19 06:58:17 PDT 
<rdar://problem/63393480>
Comment 7 Jacob Uphoff 2020-05-19 16:36:05 PDT 
Reverted r261856 for reason:

This caused internal assertion failures.

Committed r261893: <https://trac.webkit.org/changeset/261893>
Comment 8 youenn fablet 2020-05-20 00:01:22 PDT 
I cannot repro but from the log, it seems we should check whether the active video track is null or not, given we are calling processNewSample asynchronously.
Comment 9 youenn fablet 2020-05-20 00:06:07 PDT 
Created attachment 399818 [details]
Patch
Comment 10 EWS 2020-05-20 00:54:10 PDT 
Committed r261908: <https://trac.webkit.org/changeset/261908>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399818 [details].