Bug 212011 - Clean up media controls content for Apple platforms
Summary: Clean up media controls content for Apple platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-18 01:28 PDT by Antoine Quint
Modified: 2020-05-18 03:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.32 KB, patch)
2020-05-18 01:30 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (2.75 KB, patch)
2020-05-18 02:21 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-05-18 01:28:27 PDT 
Clean up media controls content for Apple platforms
Comment 1 Antoine Quint 2020-05-18 01:30:25 PDT 
Created attachment 399630 [details]
Patch
Comment 2 Antoine Quint 2020-05-18 01:30:31 PDT 
<rdar://problem/63298588>
Comment 3 Antoine Quint 2020-05-18 02:21:21 PDT 
Created attachment 399635 [details]
Patch
Comment 4 Dean Jackson 2020-05-18 03:26:59 PDT 
Comment on attachment 399635 [details]
Patch

can you remove the old media controls from the framework too?
Comment 5 Antoine Quint 2020-05-18 03:28:56 PDT 
(In reply to Dean Jackson from comment #4)
> Comment on attachment 399635 [details]
> Patch
> 
> can you remove the old media controls from the framework too?

We need to keep copying the legacy media controls files because a number of media tests rely on them and have not been updated for modern media controls.
Comment 6 EWS 2020-05-18 03:29:58 PDT 
Committed r261805: <https://trac.webkit.org/changeset/261805>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399635 [details].