RESOLVED FIXED 211972
[Apple Pay] Add testing and logging for ApplePaySetup 
https://bugs.webkit.org/show_bug.cgi?id=211972
Summary [Apple Pay] Add testing and logging for ApplePaySetup
Andy Estes
Reported 2020-05-15 15:43:39 PDT
[Apple Pay] Add testing and logging for ApplePaySetup
Attachments
Patch (58.95 KB, patch)
2020-05-15 15:48 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (61.78 KB, patch)
2020-05-15 18:00 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (61.48 KB, patch)
2020-05-18 19:39 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch for landing (61.52 KB, patch)
2020-05-18 20:17 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch for landing (61.56 KB, patch)
2020-05-18 20:22 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch for landing (61.60 KB, patch)
2020-05-18 20:28 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch for landing (70.38 KB, patch)
2020-05-19 10:38 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (68.67 KB, patch)
2020-06-05 12:45 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (68.49 KB, patch)
2020-06-05 21:46 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-05-15 15:43:59 PDT
<rdar://problem/63291965>
Andy Estes
Comment 2 2020-05-15 15:48:16 PDT
Created attachment 399523 [details] Patch
Andy Estes
Comment 3 2020-05-15 18:00:03 PDT
Created attachment 399534 [details] Patch
EWS
Comment 4 2020-05-18 08:11:23 PDT
Tools/Scripts/svn-apply failed to apply attachment 399534 [details] to trunk. Please resolve the conflicts and upload a new patch.
Andy Estes
Comment 5 2020-05-18 19:39:32 PDT Comment hidden (obsolete)
Andy Estes
Comment 6 2020-05-18 20:17:10 PDT Comment hidden (obsolete)
Andy Estes
Comment 7 2020-05-18 20:22:55 PDT Comment hidden (obsolete)
Andy Estes
Comment 8 2020-05-18 20:28:50 PDT
Created attachment 399706 [details] Patch for landing
EWS
Comment 9 2020-05-19 07:22:09 PDT
Committed r261858: <https://trac.webkit.org/changeset/261858> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399706 [details].
Andy Estes
Comment 10 2020-05-19 09:15:37 PDT
Reverted in r261864: <https://trac.webkit.org/changeset/261864>
Andy Estes
Comment 11 2020-05-19 10:38:51 PDT
Created attachment 399750 [details] Patch for landing
EWS
Comment 12 2020-05-19 11:19:28 PDT
Committed r261873: <https://trac.webkit.org/changeset/261873> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399750 [details].
Andy Estes
Comment 13 2020-05-19 13:10:27 PDT
Reverted again in r261883: <https://trac.webkit.org/changeset/261883>
Andy Estes
Comment 14 2020-06-05 12:45:57 PDT
Created attachment 401186 [details] Patch
Andy Estes
Comment 15 2020-06-05 21:46:55 PDT
Created attachment 401233 [details] Patch
EWS
Comment 16 2020-06-06 09:13:44 PDT
Committed r262682: <https://trac.webkit.org/changeset/262682> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401233 [details].
Darin Adler
Comment 17 2020-06-08 13:45:51 PDT
Comment on attachment 401233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401233&action=review > Source/WebCore/DerivedSources.make:150 > + $(WebCore)/Modules/applepay/ApplePaySetupConfiguration.idl \ Should be spaces, not a tab. > Source/WebCore/DerivedSources.make:152 > + $(WebCore)/Modules/applepay/ApplePaySetupFeatureState.idl \ Ditto.
Andy Estes
Comment 18 2020-06-09 16:29:00 PDT
(In reply to Darin Adler from comment #17) > Comment on attachment 401233 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401233&action=review > > > Source/WebCore/DerivedSources.make:150 > > + $(WebCore)/Modules/applepay/ApplePaySetupConfiguration.idl \ > > Should be spaces, not a tab. > > > Source/WebCore/DerivedSources.make:152 > > + $(WebCore)/Modules/applepay/ApplePaySetupFeatureState.idl \ > > Ditto. Fixed in r262824: <https://trac.webkit.org/changeset/262824>
Note You need to log in before you can comment on or make changes to this bug.