Bug 211971 - OES_texture_float internal format conversion must depend on WEBGL_color_buffer_float
Summary: OES_texture_float internal format conversion must depend on WEBGL_color_buffe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords: InRadar
Depends on: 210994
Blocks: 210524
  Show dependency treegraph
 
Reported: 2020-05-15 15:32 PDT by Kenneth Russell
Modified: 2020-05-15 16:58 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.46 KB, patch)
2020-05-15 15:35 PDT, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2020-05-15 15:32:17 PDT
In Bug 210994, WebKit's OES_texture_float WebGL 1.0 extension implementation was changed to modify the internal format of incoming GL_RGB or GL_RGBA textures of type GL_FLOAT. This conversion must be made conditional in order to not break the extension on iOS when OES_texture_float is exposed, since WEBGL_color_buffer_float will not be exposed on those devices.
Comment 1 Kenneth Russell 2020-05-15 15:35:29 PDT
Created attachment 399520 [details]
Patch
Comment 2 EWS 2020-05-15 16:57:28 PDT
Committed r261769: <https://trac.webkit.org/changeset/261769>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399520 [details].
Comment 3 Radar WebKit Bug Importer 2020-05-15 16:58:17 PDT
<rdar://problem/63294727>