fast/text/international/system-language/han-quotes.html fast/text/international/system-language/navigator-language/navigator-language-es-419.html fast/text/international/system-language/navigator-language/navigator-language-hi.html fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html Description: These tests are flaky crashing on iOS wk2 Debug. The earliest crash appears on 5/13/2020. History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Ftext%2Finternational%2Fsystem-language%2Fhan-quotes.html&test=fast%2Ftext%2Finternational%2Fsystem-language%2Fnavigator-language%2Fnavigator-language-es-419.html&test=fast%2Ftext%2Finternational%2Fsystem-language%2Fnavigator-language%2Fnavigator-language-hi.html&test=fast%2Ftext%2Finternational%2Fsystem-language%2Fnavigator-language%2Fnavigator-language-pt-PT.html&platform=ios&style=debug Crash log: No crash log found for com.apple.WebKit.Networking.Development:79072. stdout: stderr: ERROR: SQLite database failed to set journal_mode to WAL, error: database is locked ./platform/sql/SQLiteDatabase.cpp(208) : void WebCore::SQLiteDatabase::useWALJournalMode() ERROR: SQLite database failed to checkpoint: database is locked ./platform/sql/SQLiteDatabase.cpp(218) : void WebCore::SQLiteDatabase::useWALJournalMode() ERROR: Unable to prepare statement to fetch schema for the ObservedDomains table. /Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp(514) : void WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() SHOULD NEVER BE REACHED /Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp(515) : void WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() 1 0x11aaf3b49 WTFCrash 2 0x108cfdc6b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10942d2bf WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() 4 0x10942ce46 WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore(WebKit::WebResourceLoadStatisticsStore&, WTF::WorkQueue&, WebKit::ShouldIncludeLocalhost, WTF::String const&, PAL::SessionID) 5 0x10942dd03 WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore(WebKit::WebResourceLoadStatisticsStore&, WTF::WorkQueue&, WebKit::ShouldIncludeLocalhost, WTF::String const&, PAL::SessionID) 6 0x1094deb1c std::__1::__unique_if<WebKit::ResourceLoadStatisticsDatabaseStore>::__unique_single std::__1::make_unique<WebKit::ResourceLoadStatisticsDatabaseStore, WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&>(WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&) 7 0x1094de703 decltype(auto) WTF::makeUnique<WebKit::ResourceLoadStatisticsDatabaseStore, WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&>(WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&) 8 0x1094de456 WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore(WebKit::NetworkSession&, WTF::String const&, WebKit::ShouldIncludeLocalhost, WebCore::ResourceLoadStatistics::IsEphemeral)::$_42::operator()() const 9 0x1094de30e WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore(WebKit::NetworkSession&, WTF::String const&, WebKit::ShouldIncludeLocalhost, WebCore::ResourceLoadStatistics::IsEphemeral)::$_42, void>::call() 10 0x108de8382 WTF::Function<void ()>::operator()() const 11 0x1094b4b5e WebKit::WebResourceLoadStatisticsStore::postTask(WTF::Function<void ()>&&)::'lambda'()::operator()() const 12 0x1094b4a8e WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::postTask(WTF::Function<void ()>&&)::'lambda'(), void>::call() 13 0x11ab1f612 WTF::Function<void ()>::operator()() const 14 0x11ac2b1de WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0::operator()() const 15 0x11ac2b3d2 WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0>(WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0)::'lambda'(void*)::operator()(void*) const 16 0x11ac2b3a5 WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0>(WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0)::'lambda'(void*)::__invoke(void*) 17 0x107631951 _dispatch_call_block_and_release 18 0x1076328cb _dispatch_client_callout 19 0x10763860c _dispatch_lane_serial_drain 20 0x107639044 _dispatch_lane_invoke 21 0x1076430c4 _dispatch_workloop_worker_thread 22 0x107ab9a3d _pthread_wqthread 23 0x107ab8b77 start_wqthread
<rdar://problem/63275549>
I have marked these tests as flaky crashing while this issue is investigated. https://trac.webkit.org/changeset/261746/webkit
Created attachment 400244 [details] Patch
Comment on attachment 400244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400244&action=review > LayoutTests/ChangeLog:9 > + Tests no longer crashing. Would be better to explain why; although I was able to figure it out by reading your comments in the bug.
(In reply to Darin Adler from comment #4) > Comment on attachment 400244 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400244&action=review > > > LayoutTests/ChangeLog:9 > > + Tests no longer crashing. > > Would be better to explain why; although I was able to figure it out by > reading your comments in the bug. Good point, I'll make it clearer next time. Thanks for the review!
Committed r262160: <https://trac.webkit.org/changeset/262160> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400244 [details].