Bug 211915 – REGRESSION (r261493?): media/video-isplayingtoautomotiveheadunit.html is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ryan Haddad]

media/video-isplayingtoautomotiveheadunit.html is a flaky failure on Catalina and Mojave

--- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/media/video-isplayingtoautomotiveheadunit-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/media/video-isplayingtoautomotiveheadunit-actual.txt
@@ -10,6 +10,6 @@
 EVENT(playing)
 RUN(internals.setIsPlayingToAutomotiveHeadUnit(true))
 RUN(internals.applicationDidEnterBackground(true))
-EXPECTED (video.paused == 'false') OK
+EXPECTED (video.paused == 'false'), OBSERVED 'true' FAIL
 END OF TEST
 
https://results.webkit.org/?suite=layout-tests&test=media%2Fvideo-isplayingtoautomotiveheadunit.html

[Radar WebKit Bug Importer]

<rdar://problem/63239028>

[Ryan Haddad]

The first flake appeared on 5/11/2020 with r261534.

[Ryan Haddad]

Looking at commits in proximity, r261493 landed earlier that day:
Enable the mock video presentation mode in related layout tests and fix test failures
​https://bugs.webkit.org/show_bug.cgi?id=211645

[Peng Liu]

Created attachment 399542 [details]
Patch

[Daniel Bates]

Comment on attachment 399542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399542&action=review

> LayoutTests/media/video-isplayingtoautomotiveheadunit.html:43
> +        run('internals.setIsPlayingToAutomotiveHeadUnit(false)');

This is ok as is. No change needed. The optimal solution is for WebKitTestRunner's/DumpRenderTree's resetToConsistentState or resetInternalSettings or whatever that function is called to do this.

[Daniel Bates]

Comment on attachment 399542 [details]
Patch

Patch looks good

[EWS]

Committed r261822: <https://trac.webkit.org/changeset/261822>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399542 [details].