Bug 211913 – Attribute non-network loads and loads with html strings as automatically app-bound

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

We should consider any non-network loads or WebView loads with html strings as app-bound.

[Kate Cheney]

Created attachment 399403 [details]
Patch

[Kate Cheney]

Created attachment 399408 [details]
Patch

[Kate Cheney]

<rdar://problem/63157801>

[Brent Fulgham]

Comment on attachment 399408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399408&action=review

Looks good! I had a couple of minor suggestions.

> Source/WebKit/UIProcess/WebPageProxy.cpp:1394
> +    if (MIMEType == String("text/html") && !WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN)

if (MIMEType == "text/html"_s && !WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN)

> Source/WebKit/UIProcess/WebPageProxy.cpp:3120
> +    return requestURL.protocolIsAbout() || requestURL.protocolIsData() || requestURL.protocolIsBlob() || requestURL.isLocalFile() || requestURL.protocolIsJavaScript();

Didn't Chris have some comment on a different URL method to use for this? I can't find his comment right now. :-\

[Kate Cheney]

(In reply to Brent Fulgham from comment #4)
> Comment on attachment 399408 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399408&action=review
> 
> Looks good! I had a couple of minor suggestions.
> 

Thanks!

> > Source/WebKit/UIProcess/WebPageProxy.cpp:1394
> > +    if (MIMEType == String("text/html") && !WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN)
> 
> if (MIMEType == "text/html"_s &&
> !WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN)
> 

Will change!

> > Source/WebKit/UIProcess/WebPageProxy.cpp:3120
> > +    return requestURL.protocolIsAbout() || requestURL.protocolIsData() || requestURL.protocolIsBlob() || requestURL.isLocalFile() || requestURL.protocolIsJavaScript();
> 
> Didn't Chris have some comment on a different URL method to use for this? I
> can't find his comment right now. :-\

He suggested using !requestURL.protocolIsInHTTPFamily() in https://bugs.webkit.org/show_bug.cgi?id=208893. Since the tests use a custom URL scheme handler, they would also be included in this check. So I don't think that will work unless we figure out a way around the testing.

[Kate Cheney]

Created attachment 399431 [details]
Patch for landing

[EWS]

Committed r261727: <https://trac.webkit.org/changeset/261727>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399431 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63252340>