A number of commands in run-webkit-tests require Xcode when running on Mac, despite the fact that actually running layout tests doesn't require Xcode.
<rdar://problem/63205839>
Created attachment 399373 [details] Patch
Comment on attachment 399373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399373&action=review > Tools/Scripts/webkitpy/common/system/platforminfo.py:169 > + self._executive.run_command(['xcrun', '--version']) I don't think that this is going to fail in all configurations that we care about.
Created attachment 399381 [details] Patch
Comment on attachment 399381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399381&action=review > Tools/Scripts/webkitpy/common/system/platforminfo.py:181 > raise NotImplementedError This seems like a change in behavior that could cause an exception. For my own understanding Is there any chance this could be called in cases where there is no Xcode installed and it wouldn't be a hard failure?
(In reply to Stephanie Lewis from comment #5) > Comment on attachment 399381 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399381&action=review > > > Tools/Scripts/webkitpy/common/system/platforminfo.py:181 > > raise NotImplementedError > > This seems like a change in behavior that could cause an exception. For my > own understanding Is there any chance this could be called in cases where > there is no Xcode installed and it wouldn't be a hard failure? From what I've seen, if you don't have a macosx SDK, you won't have xcodebuild anyways, so the next command will fail with an exception. The only thing we're changing here is the exception raised.
Created attachment 399413 [details] Patch
Committed r261722: <https://trac.webkit.org/changeset/261722> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399413 [details].