RESOLVED FIXED211897
REGRESSION(r261669): [GTK] Several WebInspector tests are failing 
https://bugs.webkit.org/show_bug.cgi?id=211897
Summary REGRESSION(r261669): [GTK] Several WebInspector tests are failing
Diego Pino
Reported 2020-05-14 08:15:33 PDT
The following tests started failing since r261669: inspector/css/matched-style-properties.html [ Failure ] inspector/css/overridden-property.html [ Failure ] inspector/css/selector-specificity.html [ Failure ] inspector/css/shadow-scoped-style.html [ Failure ] inspector/css/stylesheet-with-mutations.html [ Failure ] Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261680%20(13723)/inspector/css/matched-style-properties-diff.txt --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/css/matched-style-properties-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/css/matched-style-properties-actual.txt @@ -1,10 +1,3 @@ Testing that the author rules returned by CSSStyleManager.stylesForNode have lowercase property names regardless of CSS source formatting. -Property valid: background-color -Property valid: color -Property valid: border-style -Property valid: border-width -Property valid: position -Property valid: top -Property valid: left Stderr: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261680%20(13723)/inspector/css/matched-style-properties-stderr.txt resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261680%20(13723)/inspector/css/overridden-property-diff.txt --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/css/overridden-property-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/css/overridden-property-actual.txt @@ -4,20 +4,21 @@ == Running test suite: OverriddenProperty -- Running test case: OverriddenProperty.effectivePropertyRemoved color: green; -color: red; overridden - -OverriddenStatusChanged event fired. -REMOVED color: red; +!! TIMEOUT: took longer than 10000ms -- Running test case: OverriddenProperty.OverriddenByShorthand -PASS: border-top-color is overridden. +FAIL: border-top-color is overridden. + Expected: truthy + Actual: false PASS: border-color is NOT overridden. -- Running test case: OverriddenProperty.OverriddenByImportantShorthand PASS: border-color is NOT overridden. -PASS: border-top-color is overridden. +FAIL: border-top-color is overridden. + Expected: truthy + Actual: false -- Running test case: OverriddenProperty.NotOverriddenByImportantLonghand PASS: border-top-color is NOT overridden. Stderr: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261680%20(13723)/inspector/css/overridden-property-stderr.txt resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261680%20(13723)/inspector/css/selector-specificity-diff.txt --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/css/selector-specificity-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/css/selector-specificity-actual.txt @@ -1,14 +1,3 @@ Testing that selectors have expected specificity values. -* (0, 0, 0) -h1 (0, 0, 1) -.class (0, 1, 0) -#id (1, 0, 0) -body h1.class-one.class-two (0, 2, 2) -body #foo (1, 0, 1) -body > #foo (1, 0, 1) -body > #foo.a.b (1, 2, 1) -h1::before (0, 0, 2) -body h1::before (0, 0, 3) -body.a h1.b::before (0, 2, 3) Stderr: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261680%20(13723)/inspector/css/selector-specificity-stderr.txt resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261680%20(13723)/inspector/css/shadow-scoped-style-diff.txt --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/css/shadow-scoped-style-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/css/shadow-scoped-style-actual.txt @@ -13,12 +13,6 @@ #shadow-host { padding: 5px; } -#shadow-host { - padding: 10px; -} -:host { - padding: 20px; -} address, article, aside, div, footer, header, hgroup, layer, main, nav, section { } @@ -29,9 +23,6 @@ #shadow-node { color: green; } -div { - color: blue; -} address, article, aside, div, footer, header, hgroup, layer, main, nav, section { } Stderr: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261680%20(13723)/inspector/css/shadow-scoped-style-stderr.txt resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261680%20(13723)/inspector/css/stylesheet-with-mutations-diff.txt --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/css/stylesheet-with-mutations-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/css/stylesheet-with-mutations-actual.txt @@ -1,5 +1,3 @@ Testing that we get expected values for selectors after a stylesheet has mutations. -.foo -.bar Stderr: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261680%20(13723)/inspector/css/stylesheet-with-mutations-stderr.txt resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author resource:///org/webkit/inspector/UserInterface/TestCombined.js:40434:27: CONSOLE ASSERT ERROR Unknown CSS.StyleSheetOrigin author
Attachments
Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2020-05-15 00:08:19 PDT
Fixed by r261703.
Note You need to log in before you can comment on or make changes to this bug.