Bug 211876 – Incorrect location.origin in blob workers

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Naman Nehra]

location.origin is set to "blob://" in web workers created from blobs.

[Radar WebKit Bug Importer]

<rdar://problem/63284717>

[youenn fablet]

Created attachment 399821 [details]
Patch

[Sihui Liu]

Comment on attachment 399821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399821&action=review

> Source/WebCore/workers/WorkerLocation.cpp:78
> -    return SecurityOriginData::fromURL(m_url).toString();
> +    return m_origin;

Instead of keeping m_origin, you probably want SecurityOrigin::create(m_url), which seems to handle the blob case.

[youenn fablet]

> Instead of keeping m_origin, you probably want
> SecurityOrigin::create(m_url), which seems to handle the blob case.

We are trying to reduce the number of times we create origins from background threads.
I believe we are creating the WorkerGlobalScope origin on the main thread for instance e.

Also, by reusing the WorkerGlobalScope origin, we ensure consistency and it removes the need to allocate a new SecurityOrigin object for a very short period of time.

[Sihui Liu]

(In reply to youenn fablet from comment #4)
> > Instead of keeping m_origin, you probably want
> > SecurityOrigin::create(m_url), which seems to handle the blob case.
> 
> We are trying to reduce the number of times we create origins from
> background threads.
> I believe we are creating the WorkerGlobalScope origin on the main thread
> for instance e.
> 
> Also, by reusing the WorkerGlobalScope origin, we ensure consistency and it
> removes the need to allocate a new SecurityOrigin object for a very short
> period of time.

Ah Okay, the fix should work.

[EWS]

Committed r262026: <https://trac.webkit.org/changeset/262026>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399821 [details].