Bug 211853 - Making 32-bits JIT build without Unified Build system
Summary: Making 32-bits JIT build without Unified Build system
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-13 11:20 PDT by Caio Lima
Modified: 2020-05-13 13:38 PDT (History)
8 users (show)

See Also:


Attachments
Patch (28.85 KB, patch)
2020-05-13 11:28 PDT, Caio Lima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2020-05-13 11:20:08 PDT
...
Comment 1 Caio Lima 2020-05-13 11:28:47 PDT
Created attachment 399282 [details]
Patch
Comment 2 Adrian Perez 2020-05-13 12:15:45 PDT
Comment on attachment 399282 [details]
Patch

LGTM; please make sure the EWS builders stay green before landing 🙂️
Comment 3 Mark Lam 2020-05-13 12:19:51 PDT
Comment on attachment 399282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399282&action=review

> Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:1230
> +template void JIT::emit_op_put_by_val<OpPutByVal>(const Instruction*);
> +

Why is this needed?
Comment 4 Caio Lima 2020-05-13 13:26:40 PDT
(In reply to Mark Lam from comment #3)
> Comment on attachment 399282 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399282&action=review
> 
> > Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:1230
> > +template void JIT::emit_op_put_by_val<OpPutByVal>(const Instruction*);
> > +
> 
> Why is this needed?

It is necessary to generate `JIT::emit_op_put_by_val<OpPutByVal>` and allow it be called by `JIT.cpp`. IIUC, without it, `JIT::emit_op_put_by_val<OpPutByVal>` will never be generated and we will have an issue during linking phase.
Comment 5 Caio Lima 2020-05-13 13:27:06 PDT
Comment on attachment 399282 [details]
Patch

Thank you very much for the review!
Comment 6 EWS 2020-05-13 13:37:39 PDT
Committed r261642: <https://trac.webkit.org/changeset/261642>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399282 [details].
Comment 7 Radar WebKit Bug Importer 2020-05-13 13:38:18 PDT
<rdar://problem/63197853>