Bug 211853 – Making 32-bits JIT build without Unified Build system

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Caio Lima]

...

[Caio Lima]

Created attachment 399282 [details]
Patch

[Adrian Perez]

Comment on attachment 399282 [details]
Patch

LGTM; please make sure the EWS builders stay green before landing 🙂️

[Mark Lam]

Comment on attachment 399282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399282&action=review

> Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:1230
> +template void JIT::emit_op_put_by_val<OpPutByVal>(const Instruction*);
> +

Why is this needed?

[Caio Lima]

(In reply to Mark Lam from comment #3)
> Comment on attachment 399282 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399282&action=review
> 
> > Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:1230
> > +template void JIT::emit_op_put_by_val<OpPutByVal>(const Instruction*);
> > +
> 
> Why is this needed?

It is necessary to generate `JIT::emit_op_put_by_val<OpPutByVal>` and allow it be called by `JIT.cpp`. IIUC, without it, `JIT::emit_op_put_by_val<OpPutByVal>` will never be generated and we will have an issue during linking phase.

[Caio Lima]

Comment on attachment 399282 [details]
Patch

Thank you very much for the review!

[EWS]

Committed r261642: <https://trac.webkit.org/changeset/261642>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399282 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63197853>