Bug 211847 - [buildbot] Increase blocksize of file transfer in UploadTestResults step
Summary: [buildbot] Increase blocksize of file transfer in UploadTestResults step
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-13 09:40 PDT by Diego Pino
Modified: 2020-05-15 05:33 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2020-05-13 09:44 PDT, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-05-13 09:40:17 PDT
[buildbot] Increase blocksize of file transfer in UploadTestResults step
Comment 1 Diego Pino 2020-05-13 09:44:56 PDT
Created attachment 399274 [details]
Patch
Comment 2 Diego Pino 2020-05-13 09:57:05 PDT
All other steps involving file transfers set their blocksize as 256Kb (build.webkit.org-config/steps.py:UploadBuiltProduct, ews-build/steps.py:UploadBuiltProduct and ews-build/steps.py:UploadTestResults).

In the case of the GTK and WPE test bots, the UploadTestResults is particularly slow. Digging into this issue I found out a small blocksize might be a reason for slow file transfers in Buildbot, specially in the case of big files (https://github.com/buildbot/buildbot/pull/4354). In particular, Buildbot v1.6.0 fixed this issue by making the default file transfer blocksize 256Kb, and I think this might be the reason why all the other file transfer steps have set their blocksize to this value.
Comment 3 Aakash Jain 2020-05-13 13:59:20 PDT
(In reply to Diego Pino from comment #2)
> specially in the case of big files (https://github.com/buildbot/buildbot/pull/4354). In particular, Buildbot v1.6.0 fixed this issue by making the default file transfer blocksize 256Kb
Yup! I remember making that PR in buildbot.
Comment 4 EWS 2020-05-15 05:32:13 PDT
Committed r261739: <https://trac.webkit.org/changeset/261739>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399274 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-15 05:33:12 PDT
<rdar://problem/63267637>