Bug 211824 – Add SPI for reverting to touch events for iPad trackpad interactions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Add SPI for reverting to touch events for iPad trackpad interactions

[Tim Horton]

Created attachment 399221 [details]
Patch

[Tim Horton]

<rdar://problem/61363084>

[Tim Horton]

Created attachment 399223 [details]
Patch

[Tim Horton]

Created attachment 399228 [details]
Patch

[Tim Horton]

Created attachment 399241 [details]
Patch

[Megan Gardner]

Comment on attachment 399241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399241&action=review

lots of plumbing, I wish it could be a default that could be set/read, but I know that those systems aren't a broad as is probably needed for this.

> Source/WebKit/ChangeLog:8
> +

A note maybe about being covered by existing tests + one new test?

> Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:59
> +#if TARGET_OS_IPHONE

why not #if ENABLE(IOS_TOUCH_EVENTS)?

[Tim Horton]

(In reply to Megan Gardner from comment #6)
> Comment on attachment 399241 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399241&action=review
> 
> lots of plumbing, I wish it could be a default that could be set/read, but I
> know that those systems aren't a broad as is probably needed for this.

The five-line solution (just add a switch to WKWebView) would be "fine", but WKWebpagePreferences has the additional nicety that it applies the preferences /when the page actually loads/ instead of at some random time, so it's good for things that feel like per-site quirks.
> > Source/WebKit/ChangeLog:8
> > +
> 
> A note maybe about being covered by existing tests + one new test?
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:59
> > +#if TARGET_OS_IPHONE
> 
> why not #if ENABLE(IOS_TOUCH_EVENTS)?

This is an SPI header, so the WTF feature macros aren't available.

[Wenson Hsieh]

Comment on attachment 399241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399241&action=review

LGTM as well.

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:1903
> +		4971B12E24623A3B0096994D /* basicITPDatabase.db-wal */ = {isa = PBXFileReference; lastKnownFileType = text; path = "basicITPDatabase.db-wal"; sourceTree = SOURCE_ROOT; };

0.o

[Tim Horton]

Created attachment 399288 [details]
Patch

[Tim Horton]

(In reply to Wenson Hsieh from comment #8)
> Comment on attachment 399241 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399241&action=review
> 
> LGTM as well.
> 
> > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:1903
> > +		4971B12E24623A3B0096994D /* basicITPDatabase.db-wal */ = {isa = PBXFileReference; lastKnownFileType = text; path = "basicITPDatabase.db-wal"; sourceTree = SOURCE_ROOT; };
> 
> 0.o

Xcode insists, so I am leaving it alone

[EWS]

Committed r261640: <https://trac.webkit.org/changeset/261640>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399288 [details].