Bug 211811 - The bottom value set for m_value in iterator_next should be materialized after a done getter
Summary: The bottom value set for m_value in iterator_next should be materialized afte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-12 15:53 PDT by Keith Miller
Modified: 2020-05-12 17:21 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.98 KB, patch)
2020-05-12 15:58 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (4.38 KB, patch)
2020-05-12 16:21 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-05-12 15:53:22 PDT 
The bottom value set for m_value in iterator_next should be materialized after a done getter
Comment 1 Keith Miller 2020-05-12 15:58:03 PDT 
Created attachment 399192 [details]
Patch
Comment 2 Darin Adler 2020-05-12 16:00:33 PDT 
Comment on attachment 399192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399192&action=review

> Source/JavaScriptCore/ChangeLog:13
> +        * dfg/DFGByteCodeParser.cpp:
> +        (JSC::DFG::ByteCodeParser::parseBlock):

Don’t see this change in the patch.
Comment 3 Keith Miller 2020-05-12 16:21:39 PDT 
Comment on attachment 399192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399192&action=review

>> Source/JavaScriptCore/ChangeLog:13
>> +        (JSC::DFG::ByteCodeParser::parseBlock):
> 
> Don’t see this change in the patch.

Whoops, I reverted my patch to test my changes to my test but forgot to put it back!
Comment 4 Keith Miller 2020-05-12 16:21:52 PDT 
Created attachment 399199 [details]
Patch
Comment 5 Saam Barati 2020-05-12 17:10:27 PDT 
Comment on attachment 399199 [details]
Patch

r=me
Comment 6 EWS 2020-05-12 17:14:00 PDT 
Committed r261589: <https://trac.webkit.org/changeset/261589>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399199 [details].
Comment 7 Radar WebKit Bug Importer 2020-05-12 17:21:28 PDT 
<rdar://problem/63161249>