Bug 211803 - REGRESSION(r258314): 5% regression on Membuster5
Summary: REGRESSION(r258314): 5% regression on Membuster5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-12 13:50 PDT by Jer Noble
Modified: 2020-05-12 17:16 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.27 KB, patch)
2020-05-12 13:54 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-05-12 13:50:46 PDT 
REGRESSION(r258314): 5% regression on Membuster5
Comment 1 Jer Noble 2020-05-12 13:53:29 PDT 
<rdar://problem/60609824>
Comment 2 Radar WebKit Bug Importer 2020-05-12 13:53:40 PDT 
<rdar://problem/63152408>
Comment 3 Jer Noble 2020-05-12 13:54:09 PDT 
Created attachment 399172 [details]
Patch
Comment 4 Darin Adler 2020-05-12 14:11:03 PDT 
Comment on attachment 399172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399172&action=review

> Source/WTF/ChangeLog:9
> +        Disable HAVE(AVSAMPLEBUFFERVIDEOOUTPUT), as it caused a large regression in our Membuster5 benchmark.

OK. I will note that doing this makes it sound like this is really USE(AVSAMPLEBUFFERVIDEOOUTPUT).
Comment 5 Jer Noble 2020-05-12 15:37:15 PDT 
(In reply to Darin Adler from comment #4)
> Comment on attachment 399172 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399172&action=review
> 
> > Source/WTF/ChangeLog:9
> > +        Disable HAVE(AVSAMPLEBUFFERVIDEOOUTPUT), as it caused a large regression in our Membuster5 benchmark.
> 
> OK. I will note that doing this makes it sound like this is really
> USE(AVSAMPLEBUFFERVIDEOOUTPUT).

Yep. We should probably distinguish between HAVE and USE (by just using to USE).
Comment 6 Jer Noble 2020-05-12 16:05:34 PDT 
<rdar://problem/60609824>
Comment 7 EWS 2020-05-12 17:16:31 PDT 
Committed r261590: <https://trac.webkit.org/changeset/261590>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399172 [details].