RESOLVED FIXED 211803
REGRESSION(r258314): 5% regression on Membuster5 
https://bugs.webkit.org/show_bug.cgi?id=211803
Summary REGRESSION(r258314): 5% regression on Membuster5
Jer Noble
Reported 2020-05-12 13:50:46 PDT
REGRESSION(r258314): 5% regression on Membuster5
Attachments
Patch (1.27 KB, patch)
2020-05-12 13:54 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-05-12 13:53:29 PDT
<rdar://problem/60609824>
Radar WebKit Bug Importer
Comment 2 2020-05-12 13:53:40 PDT
<rdar://problem/63152408>
Jer Noble
Comment 3 2020-05-12 13:54:09 PDT
Created attachment 399172 [details] Patch
Darin Adler
Comment 4 2020-05-12 14:11:03 PDT
Comment on attachment 399172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399172&action=review > Source/WTF/ChangeLog:9 > + Disable HAVE(AVSAMPLEBUFFERVIDEOOUTPUT), as it caused a large regression in our Membuster5 benchmark. OK. I will note that doing this makes it sound like this is really USE(AVSAMPLEBUFFERVIDEOOUTPUT).
Jer Noble
Comment 5 2020-05-12 15:37:15 PDT
(In reply to Darin Adler from comment #4) > Comment on attachment 399172 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399172&action=review > > > Source/WTF/ChangeLog:9 > > + Disable HAVE(AVSAMPLEBUFFERVIDEOOUTPUT), as it caused a large regression in our Membuster5 benchmark. > > OK. I will note that doing this makes it sound like this is really > USE(AVSAMPLEBUFFERVIDEOOUTPUT). Yep. We should probably distinguish between HAVE and USE (by just using to USE).
Jer Noble
Comment 6 2020-05-12 16:05:34 PDT
<rdar://problem/60609824>
EWS
Comment 7 2020-05-12 17:16:31 PDT
Committed r261590: <https://trac.webkit.org/changeset/261590> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399172 [details].
Note You need to log in before you can comment on or make changes to this bug.