[iOS] Play/pause button doesn't work upon first entering fullscreen mode
<rdar://problem/63118008>
Created attachment 399158 [details] Patch
Comment on attachment 399158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399158&action=review > Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:147 > + float playbackRate = isStalled() ? 0.000001 : this->playbackRate(); A magic number like this needs a "why" comment. Unless people working on media would immediately understand why this value is correct, and it’s just lack of expertise?
(In reply to Darin Adler from comment #3) > Comment on attachment 399158 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399158&action=review > > > Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:147 > > + float playbackRate = isStalled() ? 0.000001 : this->playbackRate(); > > A magic number like this needs a "why" comment. Unless people working on > media would immediately understand why this value is correct, and it’s just > lack of expertise? Hah, sure. You're right that it's an arbitrary magic number, picked so that even if your stall lasted two weeks, the scrubber would only move forward a second or so. But yes, I'll move that magic number to a static constant and add a comment before landing.
Created attachment 399169 [details] Patch for landing
Committed r261587: <https://trac.webkit.org/changeset/261587> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399169 [details].