RESOLVED FIXED211795
[iOS] Port Foreground process assertion to RunningBoard
https://bugs.webkit.org/show_bug.cgi?id=211795
Summary [iOS] Port Foreground process assertion to RunningBoard
Chris Dumez
Reported 2020-05-12 12:51:37 PDT
Port Foreground process assertion to RunningBoard.
Attachments
Patch (6.95 KB, patch)
2020-05-12 12:55 PDT, Chris Dumez
no flags
Chris Dumez
Comment 1 2020-05-12 12:51:56 PDT
Chris Dumez
Comment 2 2020-05-12 12:55:44 PDT
Geoffrey Garen
Comment 3 2020-05-12 13:10:36 PDT
Comment on attachment 399157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399157&action=review r=me > Source/WebKit/Configurations/WebKit.xcconfig:60 > +// FIXME: It is unnecessary to link against AssertionServices with the latest SDK for the following platforms too. > +WK_ASSERTION_SERVICES_LDFLAGS_watchos = -framework AssertionServices; > +WK_ASSERTION_SERVICES_LDFLAGS_watchsimulator = -framework AssertionServices; > +WK_ASSERTION_SERVICES_LDFLAGS_appletvos = -framework AssertionServices; > +WK_ASSERTION_SERVICES_LDFLAGS_appletvsimulator = -framework AssertionServices; > +WK_ASSERTION_SERVICES_LDFLAGS_maccatalyst = -framework AssertionServices; Is this about building using the old SDK? (Do we do that?)
Chris Dumez
Comment 4 2020-05-12 13:11:45 PDT
(In reply to Geoffrey Garen from comment #3) > Comment on attachment 399157 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399157&action=review > > r=me > > > Source/WebKit/Configurations/WebKit.xcconfig:60 > > +// FIXME: It is unnecessary to link against AssertionServices with the latest SDK for the following platforms too. > > +WK_ASSERTION_SERVICES_LDFLAGS_watchos = -framework AssertionServices; > > +WK_ASSERTION_SERVICES_LDFLAGS_watchsimulator = -framework AssertionServices; > > +WK_ASSERTION_SERVICES_LDFLAGS_appletvos = -framework AssertionServices; > > +WK_ASSERTION_SERVICES_LDFLAGS_appletvsimulator = -framework AssertionServices; > > +WK_ASSERTION_SERVICES_LDFLAGS_maccatalyst = -framework AssertionServices; > > Is this about building using the old SDK? (Do we do that?) Yes, we need to keep building on shipping.
EWS
Comment 5 2020-05-19 08:31:43 PDT
Committed r261860: <https://trac.webkit.org/changeset/261860> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399157 [details].
Note You need to log in before you can comment on or make changes to this bug.