Looks like another new GCC 10 warning: [625/1151] Building CXX object Source/...sources/UnifiedSource-043dd90b-1.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-1.cpp:4: /home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/BreakLines.cpp:53:78: warning: ‘visibility’ attribute ignored [-Wattributes] 53 | WEBCORE_EXPORT const unsigned char lineBreakTable[][lineBreakTableColumnCount] = { | ^ This variable does not seem to be used outside WebCore, so let's try removing it and see if EWS is happy.
Created attachment 399135 [details] Patch
Comment on attachment 399135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399135&action=review > Source/WebCore/ChangeLog:8 > + Don't export lineBreakTable. It's not used outside WebCore anyway. This comment is not accurate; it’s not what is done by this patch. Removing the WEBCORE_EXPORT from the definition does not change whether lineBreakTable is exported. That’s decided by the WEBCORE_EXPORT on the declaration in the header. I don’t know if lineBreakTable is used outside WebCore; to find out we’d have to check on the callers of all the WebCore inline functions that use lineBreakTable. If any of them are called outside WebCore, then it *is* used outside. If we wanted to not export it, then we’d have to remove the WEBCORE_EXPORT from the header. Removing this export from the .cpp file does seem like an acceptable way to fix the warning, so r=me on the code change, but please change this change log comment.
You're right! Learning is good....
Created attachment 399180 [details] Patch for landing
Committed r261580: <https://trac.webkit.org/changeset/261580> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399180 [details].
<rdar://problem/63156143>