.
Created attachment 399123 [details] Patch
Comment on attachment 399123 [details] Patch This was easier to follow after having read all the other patches in the series =) Patch LGTM, but I see an opportunity to avoid unnecessary copying of data. Please take a look and consider whether it may be good to apply the suggested change before landing. View in context: https://bugs.webkit.org/attachment.cgi?id=399123&action=review > Source/WebCore/platform/graphics/gtk/ImageGtk.cpp:64 > +GdkTexture* BitmapImage::gdkTexture() Nice refactor :) > Source/WebKit/UIProcess/API/gtk/DragSourceGtk4.cpp:59 > + GRefPtr<GBytes> bytes = adoptGRef(g_bytes_new(markup.data(), markup.length())); This (and the ones below) makes one copy if data into a CString, then another copy with g_bytes_new(). We could get the inner CStringBuffer from the CString, which is reference counted, and use that with g_bytes_new_with_free_func(). Rough idea: CString markup = m_selectionData->markup().utf8(); RefPtr<CStringBuffer> buffer = markup.buffer(); GRefPtr<GBytes> bytes = adoptGRef(g_bytes_new_with_free_func(buffer->data(), buffer->length(), [](void* data) { RefPtr<CStringBuffer> buffer = adoptRef(static_cast<CStringBuffer*>(data)); }, buffer.leakRef()));
Committed r261911: <https://trac.webkit.org/changeset/261911>