Bug 211773 - REGRESSION(r261538): [GTK] API tests are failing
Summary: REGRESSION(r261538): [GTK] API tests are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-11 23:55 PDT by Diego Pino
Modified: 2020-05-12 01:50 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (4.86 KB, patch)
2020-05-12 00:56 PDT, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-05-11 23:55:38 PDT 
API tests started failing in the interval [r261537-r261541] (See: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20(Tests)?numbuilds=50).

The EWS API-GTK bot reported the tests were failing on r261538 (https://bugs.webkit.org/show_bug.cgi?id=211729) (https://ews-build.webkit.org/#/builders/34/builds/9068). So it was either r261537 or r261538. I run the API tests on r261537 and the tests run fine (only 1 unexpected timeout and 1 unexpected pass), so the regression was introduced in r261538.
Comment 1 Mark Lam 2020-05-12 00:56:01 PDT 
Created attachment 399108 [details]
proposed patch.
Comment 2 Mark Lam 2020-05-12 00:59:43 PDT 
Comment on attachment 399108 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=399108&action=review

> Source/WebKit/ChangeLog:8
> +        Previously, we were calling Wasm::enableFastMemory().  By then, it is too late

Missing some text here.  I meant to say we were calling Wasm::enableFastMemory() in WebProcess::initializeWebProcess().
Comment 3 Yusuke Suzuki 2020-05-12 01:00:55 PDT 
Comment on attachment 399108 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2020-05-12 01:48:49 PDT 
Diego has tested the patch manually and confirmed that it resolved the API test failures on GTK.  I will land it shortly.
Comment 5 Mark Lam 2020-05-12 01:49:50 PDT 
Landed in r261549: <http://trac.webkit.org/r261549>.
Comment 6 Radar WebKit Bug Importer 2020-05-12 01:50:19 PDT 
<rdar://problem/63127074>