Bug 211772 - Fix existing usage of final/override/virtual in JSC and WTF
Summary: Fix existing usage of final/override/virtual in JSC and WTF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-11 23:23 PDT by Ross Kirsling
Modified: 2020-05-12 12:14 PDT (History)
16 users (show)

See Also:

Attachments
Patch (191.13 KB, patch)
2020-05-11 23:24 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (190.91 KB, patch)
2020-05-11 23:30 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (190.36 KB, patch)
2020-05-11 23:39 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (190.39 KB, patch)
2020-05-12 00:10 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2020-05-11 23:23:04 PDT 
Fix existing usage of final/override/virtual in JSC and WTF
Comment 1 Ross Kirsling 2020-05-11 23:24:48 PDT Comment hidden (obsolete)
Comment 2 EWS Watchlist 2020-05-11 23:25:36 PDT Comment hidden (obsolete)
Comment 3 Ross Kirsling 2020-05-11 23:26:35 PDT 
This extends the unautomable part of bug 211743 to the areas of JSC and WTF that clang-tidy didn't have a qualm with.
Comment 4 Ross Kirsling 2020-05-11 23:30:20 PDT Comment hidden (obsolete)
Comment 5 Ross Kirsling 2020-05-11 23:35:27 PDT 
(In reply to Ross Kirsling from comment #3)
> This extends the unautomable part of bug 211743 to the areas of JSC and WTF
> that clang-tidy didn't have a qualm with.

(Er rather, this patch does include modernize-use-override autofixes for WTF too, because the previous patch just touched JSC.)
Comment 6 Ross Kirsling 2020-05-11 23:39:21 PDT 
Created attachment 399105 [details]
Patch
Comment 7 Ross Kirsling 2020-05-12 00:10:55 PDT 
Created attachment 399106 [details]
Patch
Comment 8 Darin Adler 2020-05-12 09:30:02 PDT 
Comment on attachment 399106 [details]
Patch

Looks fine, rs=me
Comment 9 Ross Kirsling 2020-05-12 11:03:05 PDT 
Comment on attachment 399106 [details]
Patch

Dammit, the previous patch got rolled out; guess I'll cq- for a moment to keep things in order.
Comment 10 EWS 2020-05-12 12:13:23 PDT 
Committed r261569: <https://trac.webkit.org/changeset/261569>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399106 [details].
Comment 11 Radar WebKit Bug Importer 2020-05-12 12:14:17 PDT 
<rdar://problem/63148140>