Bug 211770 - [GTK] webaudio/codec-tests/aac/vbr-128kbps-44khz.html is failing
Summary: [GTK] webaudio/codec-tests/aac/vbr-128kbps-44khz.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-11 22:45 PDT by Diego Pino
Modified: 2020-05-21 09:51 PDT (History)
3 users (show)

See Also:


Attachments
Patch (260.22 KB, patch)
2020-05-21 09:41 PDT, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-05-11 22:45:17 PDT
Since we switched the bot to flatpak the test is returning an AUDIO error:

r260888                       PASS (Expected: PASS FAIL)
r260889                       AUDIO (Expected: PASS FAIL)
[r260890-r260894]             UNKNOWN

However the test was still passing since it was marked as a flaky failure. Then in r261540 I removed this test as it was gardened as one of the many tests that only failed in the EWS GTK-WK2 bot but it seems it's failing in GTK test bot actually.

Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261541%20(13700)/webaudio/codec-tests/aac/vbr-128kbps-44khz-diff.txt

I don't paste the diff output here because is larger than the maximum characters allowed in comments.
Comment 1 Philippe Normand 2020-05-12 05:48:05 PDT
I think it just needs a rebaseline.

NB: for audio tests, text diffs are not usefull, but expected/actual WAV files are :)
Comment 2 Lauro Moura 2020-05-19 19:08:23 PDT
This is also failing in WPE. Will move to the glib expectations.

https://results.webkit.org/?suite=layout-tests&test=webaudio%2Fcodec-tests%2Faac%2Fvbr-128kbps-44khz.html&platform=GTK&platform=WPE
Comment 3 Philippe Normand 2020-05-20 00:36:57 PDT
No test expectation update please, this just needs a rebaseline.
Comment 4 Diego Pino 2020-05-21 09:41:25 PDT
Created attachment 399960 [details]
Patch
Comment 5 Diego Pino 2020-05-21 09:50:09 PDT
Committed r262009: <https://trac.webkit.org/changeset/262009>
Comment 6 Radar WebKit Bug Importer 2020-05-21 09:51:14 PDT
<rdar://problem/63497519>