Bug 211760 - [WebAuthn] Don't assume extensions always exist
Summary: [WebAuthn] Don't assume extensions always exist
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2020-05-11 19:15 PDT by Jiewen Tan
Modified: 2020-05-12 17:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.61 KB, patch)
2020-05-11 19:20 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2020-05-11 19:15:44 PDT 
[WebAuthn] Don't assume extensions always exist.
Comment 1 Jiewen Tan 2020-05-11 19:18:00 PDT 
<rdar://problem/61217642>
Comment 2 Jiewen Tan 2020-05-11 19:20:50 PDT 
Created attachment 399087 [details]
Patch
Comment 3 Brent Fulgham 2020-05-12 16:08:35 PDT 
Comment on attachment 399087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399087&action=review

> Source/WebKit/ChangeLog:3
> +        [WebAuthn] Don't assume extensions always exist

The ASSERT_NOT_REACHED implies that we do assume these extensions exist.

I guess you mean don't treat this as a failure? But if this is a valid case, I would suggest not having the asserts.
Comment 4 Jiewen Tan 2020-05-12 17:08:53 PDT 
Comment on attachment 399087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399087&action=review

Thanks Brent for the r+.

>> Source/WebKit/ChangeLog:3
>> +        [WebAuthn] Don't assume extensions always exist
> 
> The ASSERT_NOT_REACHED implies that we do assume these extensions exist.
> 
> I guess you mean don't treat this as a failure? But if this is a valid case, I would suggest not having the asserts.

It is only valid from IPC fuzzing not real world cases. That's why I do it this way.
Comment 5 EWS 2020-05-12 17:11:07 PDT 
Committed r261588: <https://trac.webkit.org/changeset/261588>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399087 [details].