RESOLVED FIXED 211760
[WebAuthn] Don't assume extensions always exist 
https://bugs.webkit.org/show_bug.cgi?id=211760
Summary [WebAuthn] Don't assume extensions always exist
Jiewen Tan
Reported 2020-05-11 19:15:44 PDT
[WebAuthn] Don't assume extensions always exist.
Attachments
Patch (4.61 KB, patch)
2020-05-11 19:20 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2020-05-11 19:18:00 PDT
<rdar://problem/61217642>
Jiewen Tan
Comment 2 2020-05-11 19:20:50 PDT
Created attachment 399087 [details] Patch
Brent Fulgham
Comment 3 2020-05-12 16:08:35 PDT
Comment on attachment 399087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399087&action=review > Source/WebKit/ChangeLog:3 > + [WebAuthn] Don't assume extensions always exist The ASSERT_NOT_REACHED implies that we do assume these extensions exist. I guess you mean don't treat this as a failure? But if this is a valid case, I would suggest not having the asserts.
Jiewen Tan
Comment 4 2020-05-12 17:08:53 PDT
Comment on attachment 399087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399087&action=review Thanks Brent for the r+. >> Source/WebKit/ChangeLog:3 >> + [WebAuthn] Don't assume extensions always exist > > The ASSERT_NOT_REACHED implies that we do assume these extensions exist. > > I guess you mean don't treat this as a failure? But if this is a valid case, I would suggest not having the asserts. It is only valid from IPC fuzzing not real world cases. That's why I do it this way.
EWS
Comment 5 2020-05-12 17:11:07 PDT
Committed r261588: <https://trac.webkit.org/changeset/261588> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399087 [details].
Note You need to log in before you can comment on or make changes to this bug.