Fix build errors after r260992
Created attachment 399072 [details]
I'm not 100% sure this is the best fix. Another way would be to add "JSC::" to the macros in JSObject.h.
Comment on attachment 399072 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=399072&action=review
Nice catch! I think putting "JSC::" to JSC_TO_STRING_TAG_WITHOUT_TRANSITION is better if this macro is used in WebCore side too.
> + Introduce JSC::PropertyAttribute into WebCore::JSDOMIteratorPrototype() since
> + PropertyAttribute is used without JSC namespace specifier there
> + by JSC_TO_STRING_TAG_WITHOUT_TRANSITION() macro.
Let's put `JSC::` to JSC_TO_STRING_TAG_WITHOUT_TRANSITION side.
> Let's put `JSC::` to JSC_TO_STRING_TAG_WITHOUT_TRANSITION side.
Will do. Thank you!
Created attachment 399082 [details]
Comment on attachment 399082 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=399082&action=review
> + JSC_NATIVE_INTRINSIC_FUNCTION(jsName, cppName, (attributes), (length), JSC::NoIntrinsic)
This is OK. Could also have written ::JSC::NoIntrinsic, which makes this work even when inside a namespace that happens to have the identifier JSC in it.
Committed r261544: <https://trac.webkit.org/changeset/261544>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 399082 [details].