Bug 211754 - AtomString::init should temporarily disable checks via `isMainThread` due to WebThread's inconsistent state
Summary: AtomString::init should temporarily disable checks via `isMainThread` due to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-11 17:13 PDT by Yusuke Suzuki
Modified: 2020-05-11 22:22 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.54 KB, patch)
2020-05-11 18:44 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (4.54 KB, patch)
2020-05-11 18:51 PDT, Yusuke Suzuki
dino: review+
Details | Formatted Diff | Diff
Patch (5.55 KB, patch)
2020-05-11 20:03 PDT, Yusuke Suzuki
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-05-11 17:13:39 PDT
...
Comment 1 Yusuke Suzuki 2020-05-11 18:44:43 PDT
Created attachment 399083 [details]
Patch
Comment 2 Yusuke Suzuki 2020-05-11 18:51:39 PDT
Created attachment 399084 [details]
Patch
Comment 3 Yusuke Suzuki 2020-05-11 19:59:31 PDT
Comment on attachment 399084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399084&action=review

> Source/WTF/wtf/NeverDestroyed.h:132
>          MaybeRelax<T>(new (storagePointer()) T(std::forward<Args>(args)...));

Oops, I also added `storagePointerWithoutAccessCheck()`.
Comment 4 Yusuke Suzuki 2020-05-11 20:03:22 PDT
Created attachment 399091 [details]
Patch

Patch for landing
Comment 5 Yusuke Suzuki 2020-05-11 21:58:21 PDT
Comment on attachment 399091 [details]
Patch

api-ios and WK1 finishes. ios-wk2 is not related since it is not using webthread.
Comment 6 EWS 2020-05-11 21:58:58 PDT
ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.
Comment 7 Yusuke Suzuki 2020-05-11 22:21:34 PDT
Committed r261545: <https://trac.webkit.org/changeset/261545>
Comment 8 Radar WebKit Bug Importer 2020-05-11 22:22:16 PDT
<rdar://problem/63121225>