Bug 211749 - [bmalloc][WTF] Add computing memory size implementation for FreeBSD
Summary: [bmalloc][WTF] Add computing memory size implementation for FreeBSD
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-11 15:11 PDT by Basuke Suzuki
Modified: 2020-05-11 20:07 PDT (History)
8 users (show)

See Also:

Attachments
PATCH (2.76 KB, patch)
2020-05-11 16:06 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Basuke Suzuki 2020-05-11 16:06:50 PDT 
Created attachment 399063 [details]
PATCH
Comment 2 David Kilzer (:ddkilzer) 2020-05-11 19:31:53 PDT 
Comment on attachment 399063 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=399063&action=review

r=me

> Source/WTF/wtf/RAMSize.cpp:60
>      sysinfo(&si);

Should we assert that the return value here is zero (similar to what bmalloc does)?

Would also be nice to use `info` like bmalloc.

Neither of these are necessary to land this patch.
Comment 3 EWS 2020-05-11 20:06:28 PDT 
Committed r261543: <https://trac.webkit.org/changeset/261543>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399063 [details].
Comment 4 Radar WebKit Bug Importer 2020-05-11 20:07:14 PDT 
<rdar://problem/63117982>