Bug 211741 - Compile with -funwind-tables everywhere so we can always unwind
Summary: Compile with -funwind-tables everywhere so we can always unwind
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on: 211742
Blocks:
  Show dependency treegraph
 
Reported: 2020-05-11 13:39 PDT by Saam Barati
Modified: 2020-05-13 12:45 PDT (History)
15 users (show)

See Also:


Attachments
patch (27.03 KB, patch)
2020-05-11 19:44 PDT, Saam Barati
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-05-11 13:39:50 PDT
This is the default for x86, but not the default for arm64. This means on arm64 we don't be able to unwind past C/C++ frames on arm64 unless we compile with this flag.
Comment 1 Radar WebKit Bug Importer 2020-05-11 13:52:01 PDT
<rdar://problem/63104244>
Comment 2 Saam Barati 2020-05-11 19:44:07 PDT
Created attachment 399089 [details]
patch
Comment 3 EWS Watchlist 2020-05-11 19:45:19 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Saam Barati 2020-05-13 12:45:17 PDT
We're not going to do this. If we encounter more bugs in the future where this behavior matters, we'd probably choose to align behavior instead on -fno-unwind-tables. And fix bad users relying on unwinding from calling into C API.