Bug 211727 - [Flatpak] pass help argument to flatpak command not to gst-env.py
Summary: [Flatpak] pass help argument to flatpak command not to gst-env.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Víctor M. Jáquez L.
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-11 08:04 PDT by Víctor M. Jáquez L.
Modified: 2020-06-04 01:03 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.44 KB, patch)
2020-05-11 08:08 PDT, Víctor M. Jáquez L.
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Víctor M. Jáquez L. 2020-05-11 08:04:07 PDT
When running run-minibrowser --help, for example, with the envvar GST_BUILD_PATH, we get the gst-env.py help, not minibrowser's.
Comment 1 Víctor M. Jáquez L. 2020-05-11 08:08:53 PDT
Created attachment 399021 [details]
Patch
Comment 2 Philippe Normand 2020-05-11 10:01:18 PDT
Comment on attachment 399021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399021&action=review

> Tools/flatpak/flatpakutils.py:791
> +        request_help = '-h' in args or '--help' in args

Is there no better way to handle this?
Comment 3 Víctor M. Jáquez L. 2020-05-13 08:55:49 PDT
(In reply to Philippe Normand from comment #2)
> Comment on attachment 399021 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399021&action=review
> 
> > Tools/flatpak/flatpakutils.py:791
> > +        request_help = '-h' in args or '--help' in args
> 
> Is there no better way to handle this?

I'm sure there should be one, but I can't see it :S
Comment 4 Víctor M. Jáquez L. 2020-05-27 07:04:51 PDT
reopen. I thought it was other bug.
Comment 5 Víctor M. Jáquez L. 2020-05-29 10:02:09 PDT
fixed by commit r262297