Bug 211708 - Web Inspector: show JavaScript Worker name as an internal property
Summary: Web Inspector: show JavaScript Worker name as an internal property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-10 19:02 PDT by Devin Rousso
Modified: 2020-05-11 15:56 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.97 KB, patch)
2020-05-10 19:05 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-05-10 19:02:09 PDT
.
Comment 1 Devin Rousso 2020-05-10 19:05:33 PDT
Created attachment 398992 [details]
Patch
Comment 2 Joseph Pecoraro 2020-05-10 19:27:38 PDT
Comment on attachment 398992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398992&action=review

> Source/WebCore/ChangeLog:3
> +        Web Inspector: show JavaScript Worker name as an internal property

Curious! Is there no public getter for the Worker's name?! Should we propose this for the standard?
Comment 3 Devin Rousso 2020-05-11 10:40:27 PDT
Comment on attachment 398992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398992&action=review

>> Source/WebCore/ChangeLog:3
>> +        Web Inspector: show JavaScript Worker name as an internal property
> 
> Curious! Is there no public getter for the Worker's name?! Should we propose this for the standard?

It looks like it's accessible as a readonly attribute on `DedicatedWorkerGlobalScope`, but not the corresponding `Worker`.

I don't have a strong opinion about whether it should be standardized.  Could be useful I guess?  The primary motivation for this IIRC was for developer tooling anyways, so ¯\_(ツ)_/¯
Comment 4 EWS 2020-05-11 15:42:22 PDT
Committed r261499: <https://trac.webkit.org/changeset/261499>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398992 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-11 15:43:14 PDT
<rdar://problem/63109139>
Comment 6 Yusuke Suzuki 2020-05-11 15:56:01 PDT
Nice!