Bug 211706 – [clang-tidy] Run modernize-use-nullptr over JSC

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ross Kirsling]

[clang-tidy] Run modernize-use-nullptr over JSC

[Ross Kirsling]

Created attachment 398987 [details]
Patch

[Darin Adler]

Comment on attachment 398987 [details]
Patch

Looks fine. rs=me if there isn’t a mistake here somewhere that breaks compilation

[Ross Kirsling]

Thanks!

For the record, this patch is the result of running the following command:
  run-clang-tidy.py Source/JavaScriptCore -fix -checks="-*,modernize-use-nullptr" -header-filter="Source/*"`

None of changes under the API subdirectory are to C header declarations, so everything appears to be safe here.

[Darin Adler]

Comment on attachment 398987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398987&action=review

> Source/JavaScriptCore/parser/Parser.cpp:2251
> -                context.appendParameter(parameterList, parameter, 0);
> +                context.appendParameter(parameterList, parameter, nullptr);

EWS failures are about code like this. This is template code and the SyntaxChecker.h use of it will need to be changed. It uses int for this, and could instead use void* or virtually any pointer type.

[Ross Kirsling]

(In reply to Darin Adler from comment #4)
> Comment on attachment 398987 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=398987&action=review
> 
> > Source/JavaScriptCore/parser/Parser.cpp:2251
> > -                context.appendParameter(parameterList, parameter, 0);
> > +                context.appendParameter(parameterList, parameter, nullptr);
> 
> EWS failures are about code like this. This is template code and the
> SyntaxChecker.h use of it will need to be changed. It uses int for this, and
> could instead use void* or virtually any pointer type.

I think I'll split that out into a second patch just to keep this one fully-automated.

[Ross Kirsling]

Created attachment 398991 [details]
Patch for landing

[EWS]

Committed r261464: <https://trac.webkit.org/changeset/261464>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398991 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63073140>