Bug 211702 - [WinCairo][WK1] requestAnimationFrame doesn't work since r261113
Summary: [WinCairo][WK1] requestAnimationFrame doesn't work since r261113
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-10 13:26 PDT by Fujii Hironori
Modified: 2020-05-12 13:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2020-05-10 13:35 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-05-10 13:26:46 PDT 
[WinCairo][WK1] requestAnimationFrame doesn't work since r261113

Since r261113 (Bug 204713), WinCairo WK1 is failing some rAF tests.
https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/6162

fast/animation/request-animation-frame-iframe.html
fast/animation/request-animation-frame-iframe2.html
fast/animation/request-animation-frame-prefix.html
fast/animation/request-animation-frame-remove-client.html
fast/animation/request-animation-frame-remove-iframe-in-callback.html
fast/animation/request-animation-frame-timestamps-advance.html
fast/animation/request-animation-frame.html

Bug 204713 – Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler

AppleWin WK1 doesn't fail the tests.
WinCairo WK2 doesn't fail the tests.
Comment 1 Fujii Hironori 2020-05-10 13:35:18 PDT 
Created attachment 398981 [details]
Patch
Comment 2 EWS 2020-05-10 19:08:40 PDT 
Committed r261463: <https://trac.webkit.org/changeset/261463>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398981 [details].
Comment 3 Radar WebKit Bug Importer 2020-05-10 19:09:20 PDT 
<rdar://problem/63072619>
Comment 4 Fujii Hironori 2020-05-11 14:48:07 PDT 
r261463 actually fixed the rAF timeout issue of WinCairo testing bot.
https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/6245

However, surprisingly, rAF still doesn't work well in WinCairo WK1 MiniBrowser. I will file a new bug.
Comment 5 Fujii Hironori 2020-05-12 13:21:24 PDT 
Filed: Bug 211798 – [WinCairo][WK1] requestAnimationFrame doesn't work since r244182 in Accelerated Compositing mode