Bug 211698 – Use alias template to define `match_constness` in Wtf/wtp/TypeCasts.h

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Tetsuharu Ohzeki [UTC+9]]

This is pretty trivial change....
May I change this?

[Tetsuharu Ohzeki [UTC+9]]

Created attachment 398977 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 398977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398977&action=review

r=me with nit.

> Source/WTF/wtf/TypeCasts.h:71
> +using match_constness =
> +    typename std::conditional<std::is_const<Reference>::value, typename std::add_const<T>::type, typename std::remove_const<T>::type>::type;

`match_correctness` looks like not following to the WebKit's naming convention. Based on https://bugs.webkit.org/show_bug.cgi?id=140905#c4, I guess that this is intentionally using C++ STL's naming convention here.
Then, can you change this to `match_constness_t`? When using alias template and generating type without using `::type`, C++ STL uses `_t` suffix. e.g. https://en.cppreference.com/w/cpp/types/make_signed

[Tetsuharu Ohzeki [UTC+9]]

Created attachment 398990 [details]
Patch

[Tetsuharu Ohzeki [UTC+9]]

Comment on attachment 398990 [details]
Patch

Yusuke, could you review this patch again?

[EWS]

Committed r261465: <https://trac.webkit.org/changeset/261465>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398990 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63075552>

[Darin Adler]

Comment on attachment 398990 [details]
Patch

Surprised that the standard library doesn’t have something like this.

[Darin Adler]

Comment on attachment 398990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398990&action=review

> Source/WTF/wtf/TypeCasts.h:71
> +    typename std::conditional<std::is_const<Reference>::value, typename std::add_const<T>::type, typename std::remove_const<T>::type>::type;

As long as we are modernizing, should use conditional_t, is_const_v, add_const_t, and remove_const_t.