Bug 211691 – [WebGPU] Implement texture views

• Status: NEW
• Component: New Bugs

[Myles C. Maxfield]

[WebGPU] Implement texture views

[Myles C. Maxfield]

Created attachment 398970 [details]
WIP

[Myles C. Maxfield]

<rdar://problem/54533652>

[Myles C. Maxfield]

Comment on attachment 398970 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=398970&action=review

> Source/WebCore/ChangeLog:11
> +        - Figure out what to do about GPUTextureAspect

Also delete createDefaultView(), and make sure default values work.

[Myles C. Maxfield]

Comment on attachment 398970 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=398970&action=review

>> Source/WebCore/ChangeLog:11
>> +        - Figure out what to do about GPUTextureAspect
> 
> Also delete createDefaultView(), and make sure default values work.

Also also: Write all the stuff in this patch in the spec: https://gpuweb.github.io/gpuweb/#textureview-createview

[Myles C. Maxfield]

Comment on attachment 398970 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=398970&action=review

> Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:360
> +    texture = adoptNS([m_platformTexture newTextureViewWithPixelFormat:metalPixelFormat textureType:textureType.value() levels:levels.value() slices:slices.value()]);

If the view is the same as the underlying texture, we can avoid this call.

[Myles C. Maxfield]

From the spec:

> optional GPUTextureViewDescriptor descriptor = {}

This doesn't make sense to me.

[Myles C. Maxfield]

Created attachment 399714 [details]
Rebased

[Myles C. Maxfield]

mipLevelCount: If 0, defaults to texture.mipLevelCount − baseMipLevel.
arrayLayerCount: If 0, defaults to texture.size.depth − baseArrayLayer.

[Myles C. Maxfield]

> If texture.size.depth is greater than 1 and arrayLayerCount is 0

This seems kind of silly

[Myles C. Maxfield]

Comment on attachment 399714 [details]
Rebased

View in context: https://bugs.webkit.org/attachment.cgi?id=399714&action=review

> Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:308
> +            return parentSampleCount == 1 ? MTLTextureType2DArray : MTLTextureType2DMultisampleArray;

MTLTextureType2DMultisampleArray doesn't exist on iOS