RESOLVED FIXED 21169
Profile's Self and Total columns should not when when searching without units 
https://bugs.webkit.org/show_bug.cgi?id=21169
Summary Profile's Self and Total columns should not when when searching without units
Timothy Hatcher
Reported 2008-09-26 22:57:54 PDT
Currently doing a numeric search in Profiles without a unit assumes milliseconds. But this is confusing when viewing the columns as percents. So we should match both numbers when the units are not specified. And when viewing the column that didn't match and there are matches for the other unit, show the cells with a diagonal pattern to show the other unit matches.
Attachments
Proposed design (103.13 KB, image/png)
2008-09-26 22:58 PDT, Timothy Hatcher 		no flags
Details
Proposed patch (4.02 KB, patch)
2008-09-27 13:05 PDT, Timothy Hatcher 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2008-09-26 22:58:15 PDT
Created attachment 23871 [details] Proposed design
Timothy Hatcher
Comment 2 2008-09-27 13:00:08 PDT
I have decided it would be best not to match the Self and Total columns when there are no units. We would only match the Calls column. In practice this feels better and is easier to understand.
Timothy Hatcher
Comment 3 2008-09-27 13:05:05 PDT
Created attachment 23879 [details] Proposed patch
Timothy Hatcher
Comment 4 2008-09-27 13:18:28 PDT
Landed in r37004.
Note You need to log in before you can comment on or make changes to this bug.