Bug 21169 - Profile's Self and Total columns should not when when searching without units
: Profile's Self and Total columns should not when when searching without units
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-09-26 22:57 PST by
Modified: 2008-09-27 13:18 PST (History)


Attachments
Proposed design (103.13 KB, image/png)
2008-09-26 22:58 PST, Timothy Hatcher
no flags Details
Proposed patch (4.02 KB, patch)
2008-09-27 13:05 PST, Timothy Hatcher
sam: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-09-26 22:57:54 PST
Currently doing a numeric search in Profiles without a unit assumes milliseconds. But this is confusing when viewing the columns as percents. So we should match both numbers when the units are not specified. And when viewing the column that didn't match and there are matches for the other unit, show the cells with a diagonal pattern to show the other unit matches.
------- Comment #1 From 2008-09-26 22:58:15 PST -------
Created an attachment (id=23871) [details]
Proposed design
------- Comment #2 From 2008-09-27 13:00:08 PST -------
I have decided it would be best not to match the Self and Total columns when there are no units. We would only match the Calls column. In practice this feels better and is easier to understand.
------- Comment #3 From 2008-09-27 13:05:05 PST -------
Created an attachment (id=23879) [details]
Proposed patch
------- Comment #4 From 2008-09-27 13:18:28 PST -------
Landed in r37004.