Bug 21169 - Profile's Self and Total columns should not when when searching without units
Summary: Profile's Self and Total columns should not when when searching without units
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
Depends on:
Reported: 2008-09-26 22:57 PDT by Timothy Hatcher
Modified: 2008-09-27 13:18 PDT (History)
3 users (show)

See Also:

Proposed design (103.13 KB, image/png)
2008-09-26 22:58 PDT, Timothy Hatcher
no flags Details
Proposed patch (4.02 KB, patch)
2008-09-27 13:05 PDT, Timothy Hatcher
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2008-09-26 22:57:54 PDT
Currently doing a numeric search in Profiles without a unit assumes milliseconds. But this is confusing when viewing the columns as percents. So we should match both numbers when the units are not specified. And when viewing the column that didn't match and there are matches for the other unit, show the cells with a diagonal pattern to show the other unit matches.
Comment 1 Timothy Hatcher 2008-09-26 22:58:15 PDT
Created attachment 23871 [details]
Proposed design
Comment 2 Timothy Hatcher 2008-09-27 13:00:08 PDT
I have decided it would be best not to match the Self and Total columns when there are no units. We would only match the Calls column. In practice this feels better and is easier to understand.
Comment 3 Timothy Hatcher 2008-09-27 13:05:05 PDT
Created attachment 23879 [details]
Proposed patch
Comment 4 Timothy Hatcher 2008-09-27 13:18:28 PDT
Landed in r37004.