Bug 211662 - Remove HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI
Summary: Remove HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-08 23:45 PDT by David Quesada
Modified: 2020-05-09 09:02 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.62 KB, patch)
2020-05-08 23:55 PDT, David Quesada 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Quesada 2020-05-08 23:45:56 PDT 
On all UIKit-having platforms that WebKit suports building for, UIScrollView has the SPI -_flashScrollIndicatorsForAxes:persistingPreviousFlashes:. The HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI platform conditional is therefore no longer necessary, and its current NO value for Mac Catalyst actually makes us send a message (_flashScrollIndicatorsPersistingPreviousFlashes:) that UIScrollView no longer responds to.
Comment 1 Radar WebKit Bug Importer 2020-05-08 23:46:15 PDT 
<rdar://problem/63048713>
Comment 2 David Quesada 2020-05-08 23:55:21 PDT 
Created attachment 398920 [details]
Patch
Comment 3 Darin Adler 2020-05-09 08:38:53 PDT 
Comment on attachment 398920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398920&action=review

> Source/WebKit/ChangeLog:12
> +        Remove this platform conditional and unconditionally use -[UIScrolView _flashScrollIndicatorsForAxes:
> +        persistingPreviousFlashes:]. All supported platforms with UIScrollView have this SPI, and the conditional
> +        was excluding Mac Catalyst, making WKKeyboardScrollViewAnimator send a message to its scroll view that
> +        is no longer implemented.

Seems like the headline here is fixing the bug on Mac Catalyst; a crash maybe?

Removing the HAVE macro is the less important half of this, as grateful as I am to have that cleaned up too.
Comment 4 EWS 2020-05-09 09:02:31 PDT 
Committed r261436: <https://trac.webkit.org/changeset/261436>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398920 [details].