Bug 211657 - Re-enable 'VisuallyIdle' RenderingUpdate throttling
Summary: Re-enable 'VisuallyIdle' RenderingUpdate throttling
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-08 20:06 PDT by Said Abou-Hallawa
Modified: 2020-05-15 19:02 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.04 KB, patch)
2020-05-09 00:59 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (19.59 KB, patch)
2020-05-15 14:22 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (20.18 KB, patch)
2020-05-15 17:04 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (33.21 KB, patch)
2020-05-15 19:02 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-05-08 20:06:11 PDT 
The VisuallyIdle throttling was not implemented in r261113. The goal of the VisuallyIdle throttling is to save power by throttling the RenderingUpdate when the Page is VisuallyIdle. The page is in 'VisuallyIdle' state when it is invisible or when the Window server stopped modifying the host application.
Comment 1 Said Abou-Hallawa 2020-05-09 00:59:47 PDT 
Created attachment 398921 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-05-11 10:33:21 PDT 
Comment on attachment 398921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398921&action=review

> Source/WebCore/platform/graphics/AnimationFrameRate.h:77
>  inline TextStream& operator<<(TextStream& ts, const OptionSet<ThrottlingReason>& reasons)

TextStream already knows how to dump OptionSet<>, so you just need dumping for ThrottlingReason.
Comment 3 Said Abou-Hallawa 2020-05-15 14:22:35 PDT 
Created attachment 399511 [details]
Patch
Comment 4 Said Abou-Hallawa 2020-05-15 17:04:16 PDT 
Created attachment 399528 [details]
Patch
Comment 5 Said Abou-Hallawa 2020-05-15 19:02:57 PDT 
Created attachment 399538 [details]
Patch