Bug 211642 - webkitpy: 'iPhone SE' should match 'iPhone SE 1st generation'
Summary: webkitpy: 'iPhone SE' should match 'iPhone SE 1st generation'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-08 13:58 PDT by Jonathan Bedard
Modified: 2020-05-23 06:06 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.76 KB, patch)
2020-05-08 14:03 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (6.96 KB, patch)
2020-05-08 15:03 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (6.96 KB, patch)
2020-05-08 15:09 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-05-08 13:58:15 PDT 
In general, model matching should work such that '<model> 1st generation' matches '<model>'
Comment 1 Jonathan Bedard 2020-05-08 14:00:05 PDT 
<rdar://problems/62986242>
Comment 2 Jonathan Bedard 2020-05-08 14:03:28 PDT 
Created attachment 398886 [details]
Patch
Comment 3 Aakash Jain 2020-05-08 14:18:31 PDT 
Comment on attachment 398886 [details]
Patch

rs=me
Comment 4 Alexey Proskuryakov 2020-05-08 14:46:45 PDT 
Comment on attachment 398886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398886&action=review

> Tools/Scripts/webkitpy/xcode/device_type_unittest.py:164
> +        self.assertTrue(DeviceType.from_string('iPhone SE') == DeviceType.from_string('iPhone SE 1st generation'))

Is this the actual string? I thought that there were parentheses there.
Comment 5 Jonathan Bedard 2020-05-08 15:03:08 PDT 
Created attachment 398893 [details]
Patch
Comment 6 Jonathan Bedard 2020-05-08 15:06:57 PDT 
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 398886 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=398886&action=review
> 
> > Tools/Scripts/webkitpy/xcode/device_type_unittest.py:164
> > +        self.assertTrue(DeviceType.from_string('iPhone SE') == DeviceType.from_string('iPhone SE 1st generation'))
> 
> Is this the actual string? I thought that there were parentheses there.

There are, and I missed a check we need in the case that we don't have an existing simulator with the type. Uploaded a new patch.
Comment 7 Jonathan Bedard 2020-05-08 15:09:57 PDT 
Created attachment 398896 [details]
Patch for landing
Comment 8 EWS 2020-05-08 15:56:52 PDT 
Committed r261421: <https://trac.webkit.org/changeset/261421>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398896 [details].