Bug 211640 – Fix wpt shadow-dom/slots-fallback-in-document.html

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Tetsuharu Ohzeki [UTC+9]]

Today's webkit does not green: http://wpt.live/shadow-dom/slots-fallback-in-document.html

[Tetsuharu Ohzeki [UTC+9]]

I'll attach the patch.

[Tetsuharu Ohzeki [UTC+9]]

Created attachment 398885 [details]
Patch

[Darin Adler]

Comment on attachment 398885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398885&action=review

> Source/WebCore/html/HTMLSlotElement.cpp:123
> -        if (is<HTMLSlotElement>(*node))
> +        if (is<HTMLSlotElement>(*node) && downcast<HTMLSlotElement>(*node).containingShadowRoot())

Why is this different from the code above that iterates children?

[Tetsuharu Ohzeki [UTC+9]]

(In reply to Darin Adler from comment #3)
> Comment on attachment 398885 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=398885&action=review
> 
> > Source/WebCore/html/HTMLSlotElement.cpp:123
> > -        if (is<HTMLSlotElement>(*node))
> > +        if (is<HTMLSlotElement>(*node) && downcast<HTMLSlotElement>(*node).containingShadowRoot())
> 
> Why is this different from the code above that iterates children?

This condition changing is correspond to the spec[1], step 5-1-1.

[1]: https://dom.spec.whatwg.org/#find-flattened-slotables

[Tetsuharu Ohzeki [UTC+9]]

As sideeffect, this change also fix http://wpt.live/shadow-dom/slots-outside-shadow-dom.html. I'll upload the patch which updates wpt results.

[Tetsuharu Ohzeki [UTC+9]]

Created attachment 398919 [details]
Patch

[Ryosuke Niwa]

Are you a committer? If not, can you also set cq? when your patch is ready to land. Then any committer (including myself) can set it to cq+, which allows your patch to be committed into the WebKit repository.

[Ryosuke Niwa]

(In reply to Ryosuke Niwa from comment #7)
> Are you a committer? If not, can you also set cq? when your patch is ready
> to land. Then any committer (including myself) can set it to cq+, which
> allows your patch to be committed into the WebKit repository.

You can do this via "Details".

[Tetsuharu Ohzeki [UTC+9]]

(In reply to Ryosuke Niwa from comment #7)
> Are you a committer? If not, can you also set cq? when your patch is ready
> to land. Then any committer (including myself) can set it to cq+, which
> allows your patch to be committed into the WebKit repository.


Thank you for your guide, niwa san.
I'm not a comitter, so I'll set cq?.

[Ryosuke Niwa]

Comment on attachment 398919 [details]
Patch

Great. Thanks for the patch!

[EWS]

Committed r261433: <https://trac.webkit.org/changeset/261433>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398919 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63048867>