Bug 211627 - [GStreamer] Audio messages in web.whatsapp.com only play once.
Summary: [GStreamer] Audio messages in web.whatsapp.com only play once.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-08 08:46 PDT by Hussam Al-Tayeb
Modified: 2020-05-12 01:50 PDT (History)
13 users (show)

See Also:


Attachments
Patch (2.05 KB, patch)
2020-05-09 03:52 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (5.42 KB, patch)
2020-05-11 03:57 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (5.46 KB, patch)
2020-05-12 00:15 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hussam Al-Tayeb 2020-05-08 08:46:48 PDT
I have an issue with web.whatsapp.com where audio messages only play once. I cannot press play again once the message finishes playing.
I am using webkitgtk 2.28.2
Comment 1 Hussam Al-Tayeb 2020-05-08 08:48:40 PDT
(In reply to Hussam Al-Tayeb from comment #0)
> I have an issue with web.whatsapp.com where audio messages only play once. I
> cannot press play again once the message finishes playing.
> I am using webkitgtk 2.28.2

This is a major issue for me because with reduced office hours, my employer sends me a large amount of whatsapp instructional messages which I have to listen to more than once while transcribing them.
Comment 2 Philippe Normand 2020-05-09 03:52:07 PDT
Created attachment 398923 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2020-05-10 23:27:23 PDT
Comment on attachment 398923 [details]
Patch

Can you please write a test for this?
Comment 4 Philippe Normand 2020-05-11 03:57:23 PDT
Created attachment 399010 [details]
Patch
Comment 5 Philippe Normand 2020-05-11 04:12:17 PDT
Comment on attachment 399010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399010&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2704
> +    if (m_url.protocolIs("blob"_s)) {

Hah. Should use protocolIsBlob().
Comment 6 Philippe Normand 2020-05-12 00:15:52 PDT
Created attachment 399107 [details]
Patch
Comment 7 EWS 2020-05-12 01:50:01 PDT
Committed r261550: <https://trac.webkit.org/changeset/261550>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399107 [details].