RESOLVED FIXED 211591
[iOS] caret appears in the middle of a search field when field is focused on agoda.com 
https://bugs.webkit.org/show_bug.cgi?id=211591
Summary [iOS] caret appears in the middle of a search field when field is focused on ...
Wenson Hsieh
Reported 2020-05-07 13:06:28 PDT
<rdar://problem/60605873>
Attachments
Patch (16.60 KB, patch)
2020-05-07 13:46 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix #include order (16.61 KB, patch)
2020-05-07 13:48 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rebase on trunk (16.58 KB, patch)
2020-05-07 14:45 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (14.85 KB, patch)
2020-05-08 07:45 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Remove unnecessary local variable (14.80 KB, patch)
2020-05-08 07:47 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-05-07 13:46:03 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2020-05-07 13:48:49 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2020-05-07 14:45:05 PDT Comment hidden (obsolete)
Antoine Quint
Comment 4 2020-05-08 01:22:24 PDT
I'd rather we didn't add the animationDidFinish() method on AnimationEffect/KeyframeEffect. The other animationDid*() method are there because KeyframeEffect need to update accelerated animations based on a timing change in its associated WebAnimation, but here this is not the case. I suggest we simply call through KeyframeEffect to obtain the target right from WebAnimation::finishNotificationSteps() leaving AnimationEffect/KeyframeEffect untouched.
Wenson Hsieh
Comment 5 2020-05-08 07:07:55 PDT
Comment on attachment 398799 [details] Rebase on trunk (In reply to Antoine Quint from comment #4) > I'd rather we didn't add the animationDidFinish() method on > AnimationEffect/KeyframeEffect. The other animationDid*() method are there > because KeyframeEffect need to update accelerated animations based on a > timing change in its associated WebAnimation, but here this is not the case. > I suggest we simply call through KeyframeEffect to obtain the target right > from WebAnimation::finishNotificationSteps() leaving > AnimationEffect/KeyframeEffect untouched. 👍🏻
Wenson Hsieh
Comment 6 2020-05-08 07:45:18 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 7 2020-05-08 07:47:21 PDT
Created attachment 398860 [details] Remove unnecessary local variable
EWS
Comment 8 2020-05-08 10:57:44 PDT
Committed r261398: <https://trac.webkit.org/changeset/261398> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398860 [details].
Note You need to log in before you can comment on or make changes to this bug.