Bug 211591 - [iOS] caret appears in the middle of a search field when field is focused on agoda.com
Summary: [iOS] caret appears in the middle of a search field when field is focused on ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-07 13:06 PDT by Wenson Hsieh
Modified: 2020-05-08 10:57 PDT (History)
12 users (show)

See Also:

Attachments
Patch (16.60 KB, patch)
2020-05-07 13:46 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix #include order (16.61 KB, patch)
2020-05-07 13:48 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Rebase on trunk (16.58 KB, patch)
2020-05-07 14:45 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (14.85 KB, patch)
2020-05-08 07:45 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Remove unnecessary local variable (14.80 KB, patch)
2020-05-08 07:47 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-05-07 13:06:28 PDT 
<rdar://problem/60605873>
Comment 1 Wenson Hsieh 2020-05-07 13:46:03 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2020-05-07 13:48:49 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2020-05-07 14:45:05 PDT Comment hidden (obsolete)
Comment 4 Antoine Quint 2020-05-08 01:22:24 PDT 
I'd rather we didn't add the animationDidFinish() method on AnimationEffect/KeyframeEffect. The other animationDid*() method are there because KeyframeEffect need to update accelerated animations based on a timing change in its associated WebAnimation, but here this is not the case. I suggest we simply call through KeyframeEffect to obtain the target right from WebAnimation::finishNotificationSteps() leaving AnimationEffect/KeyframeEffect untouched.
Comment 5 Wenson Hsieh 2020-05-08 07:07:55 PDT 
Comment on attachment 398799 [details]
Rebase on trunk

(In reply to Antoine Quint from comment #4)
> I'd rather we didn't add the animationDidFinish() method on
> AnimationEffect/KeyframeEffect. The other animationDid*() method are there
> because KeyframeEffect need to update accelerated animations based on a
> timing change in its associated WebAnimation, but here this is not the case.
> I suggest we simply call through KeyframeEffect to obtain the target right
> from WebAnimation::finishNotificationSteps() leaving
> AnimationEffect/KeyframeEffect untouched.

👍🏻
Comment 6 Wenson Hsieh 2020-05-08 07:45:18 PDT Comment hidden (obsolete)
Comment 7 Wenson Hsieh 2020-05-08 07:47:21 PDT 
Created attachment 398860 [details]
Remove unnecessary local variable
Comment 8 EWS 2020-05-08 10:57:44 PDT 
Committed r261398: <https://trac.webkit.org/changeset/261398>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398860 [details].