<rdar://problem/60605873>
Created attachment 398792 [details] Patch
Created attachment 398793 [details] Fix #include order
Created attachment 398799 [details] Rebase on trunk
I'd rather we didn't add the animationDidFinish() method on AnimationEffect/KeyframeEffect. The other animationDid*() method are there because KeyframeEffect need to update accelerated animations based on a timing change in its associated WebAnimation, but here this is not the case. I suggest we simply call through KeyframeEffect to obtain the target right from WebAnimation::finishNotificationSteps() leaving AnimationEffect/KeyframeEffect untouched.
Comment on attachment 398799 [details] Rebase on trunk (In reply to Antoine Quint from comment #4) > I'd rather we didn't add the animationDidFinish() method on > AnimationEffect/KeyframeEffect. The other animationDid*() method are there > because KeyframeEffect need to update accelerated animations based on a > timing change in its associated WebAnimation, but here this is not the case. > I suggest we simply call through KeyframeEffect to obtain the target right > from WebAnimation::finishNotificationSteps() leaving > AnimationEffect/KeyframeEffect untouched. 👍🏻
Created attachment 398858 [details] Patch
Created attachment 398860 [details] Remove unnecessary local variable
Committed r261398: <https://trac.webkit.org/changeset/261398> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398860 [details].