Bug 211584 - webkitpy: Use apple_additions certificate path if available
Summary: webkitpy: Use apple_additions certificate path if available
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-07 10:45 PDT by Jonathan Bedard
Modified: 2020-05-07 13:17 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.50 KB, patch)
2020-05-07 10:49 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (2.50 KB, patch)
2020-05-07 11:36 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (2.50 KB, patch)
2020-05-07 12:40 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-05-07 10:45:52 PDT 
We should use the certificate path form apple_additions if it's available.
Comment 1 Jonathan Bedard 2020-05-07 10:49:25 PDT 
Created attachment 398762 [details]
Patch
Comment 2 Jonathan Bedard 2020-05-07 11:36:06 PDT 
Created attachment 398770 [details]
Patch
Comment 3 Aakash Jain 2020-05-07 12:01:16 PDT 
Comment on attachment 398770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398770&action=review

> Tools/Scripts/webkitpy/results/upload.py:185
> +        import certifi

Do all the machine have certifi? Should we have a try except here?
Comment 4 Jonathan Bedard 2020-05-07 12:14:58 PDT 
(In reply to Aakash Jain from comment #3)
> Comment on attachment 398770 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=398770&action=review
> 
> > Tools/Scripts/webkitpy/results/upload.py:185
> > +        import certifi
> 
> Do all the machine have certifi? Should we have a try except here?

Yes. It's a dependency of requests, which we autoinstall in this file. So it's guaranteed to be on your Python path.
Comment 5 Aakash Jain 2020-05-07 12:17:33 PDT 
rs=me
Comment 6 Jonathan Bedard 2020-05-07 12:40:47 PDT 
Created attachment 398776 [details]
Patch for landing
Comment 7 EWS 2020-05-07 13:16:03 PDT 
Committed r261332: <https://trac.webkit.org/changeset/261332>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398776 [details].
Comment 8 Radar WebKit Bug Importer 2020-05-07 13:17:14 PDT 
<rdar://problem/62990117>