Bug 211532 - Add a test for `REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange`
Summary: Add a test for `REGRESSION (r260753): Frequent crashes under TextIndicator's ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-06 14:30 PDT by Tim Horton
Modified: 2020-05-07 11:39 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.19 KB, patch)
2020-05-06 14:31 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-05-06 14:30:47 PDT 
Add a test for `REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange`
Comment 1 Tim Horton 2020-05-06 14:31:09 PDT 
Created attachment 398658 [details]
Patch
Comment 2 EWS 2020-05-06 14:54:07 PDT 
Committed r261251: <https://trac.webkit.org/changeset/261251>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398658 [details].
Comment 3 Radar WebKit Bug Importer 2020-05-06 14:55:14 PDT 
<rdar://problem/62946934>
Comment 4 Aakash Jain 2020-05-07 08:34:17 PDT 
(In reply to EWS from comment #2)
> Committed r261251: <https://trac.webkit.org/changeset/261251>
The newly added test fast/text-indicator/text-indicator-estimated-color-with-implicit-newline.html seems to be failing consistently on ios-wk2, as also indicated by red ews bubble.

History: https://results.webkit.org/?suite=layout-tests&test=fast%2Ftext-indicator%2Ftext-indicator-estimated-color-with-implicit-newline.html
Comment 5 Ryan Haddad 2020-05-07 09:23:41 PDT 
Reverted r261251 for reason:

Test is failing on iOS

Committed r261295: <https://trac.webkit.org/changeset/261295>
Comment 6 Tim Horton 2020-05-07 11:39:20 PDT 
https://trac.webkit.org/changeset/261321/webkit